test(gax): Error Logging Integration Test#12329
Draft
westarle wants to merge 2 commits intogoogleapis:mainfrom
Draft
test(gax): Error Logging Integration Test#12329westarle wants to merge 2 commits intogoogleapis:mainfrom
westarle wants to merge 2 commits intogoogleapis:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces integration tests for actionable error logging in both gRPC and HTTP/JSON transports, along with necessary build configuration updates in the GAX and Showcase modules. The changes include a new Maven profile for running environment-specific tests and the addition of the ITActionableErrorsLogging test suite. Review feedback focuses on narrowing the scope of included service providers in the POM to avoid bundling unnecessary files, centralizing dependency version management, removing unused imports and variables, and ensuring proper resource cleanup by calling awaitTermination after closing clients in tests.
...showcase/src/test/java/com/google/showcase/v1beta1/it/logging/ITActionableErrorsLogging.java
Outdated
Show resolved
Hide resolved
...showcase/src/test/java/com/google/showcase/v1beta1/it/logging/ITActionableErrorsLogging.java
Outdated
Show resolved
Hide resolved
...showcase/src/test/java/com/google/showcase/v1beta1/it/logging/ITActionableErrorsLogging.java
Outdated
Show resolved
Hide resolved
...showcase/src/test/java/com/google/showcase/v1beta1/it/logging/ITActionableErrorsLogging.java
Show resolved
Hide resolved
c3dd40f to
0160d5b
Compare
0160d5b to
ed93f27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an automated integration test (
ITActionableErrorsLogging) to ensure end-to-end functionality of the Actionable Errors logging framework against a livegapic-showcaseserver.ITActionableErrorsLoggingto verify thatLoggingTracercorrectly extracts and emitsgoogle.rpc.ErrorInfocontext (reason, domain, and metadata) as structuredDEBUGlogs during failed attempts.TestLoggerandTestServiceProviderimplementation provided bygax-testlib.gaxandgapic-showcasepom.xmlfiles to correctly exposeMETA-INF/services/**and include the test exclusively when the-PenvVarTestprofile isactivated.
MockHttpTransportto simulate the correct JSON error payload for REST).