feature(internal/sidekick/surfer): operations commands#5798
Merged
Conversation
sarahheacock
added
the
surfer
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements support for Long Running Operations (LRO) within the surfer tool. Key changes include the synthesis of 'wait' commands for operation resources, the introduction of a new LRO mixin provider for identifying and documenting operation methods, and enhanced resource discovery that can infer operation resources from path patterns. Additionally, the PR updates argument building logic to handle LRO-specific fields and provides comprehensive test coverage, including updated golden files for several APIs. I have no feedback to provide.
jameslynnwu
requested changes
May 4, 2026
sarahheacock
force-pushed
the
surfer-operations
branch
5 times, most recently
from
41b4539 to
2d1f28a
Compare
Finish implementation of operations commands. - Infers resource from operation method patterns to populate resource argument. - Adds new mixins file to provide missing information such as documentation. - Build wait command from get method - Skip return_partial_success field since not available on all APIs Fixes googleapis#5485
sarahheacock
force-pushed
the
surfer-operations
branch
from
2d1f28a to
d48b5db
Compare
jameslynnwu
requested changes
May 5, 2026
jameslynnwu
requested changes
May 5, 2026
jameslynnwu
approved these changes
May 5, 2026
sofisl
pushed a commit
that referenced
this pull request
May 5, 2026
- Infers resource from operation method patterns to populate resource argument. Resource descriptors are not available for operation mixins - Adds new mixins file to provide missing information such as documentation. - Skip return_partial_success field since not available on all APIs For #5485
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #5485