feat(internal/librarian/java): support showcase as source in generate#5799
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the Java librarian to support multiple proto source directories by introducing a librarySources struct. This change allows the generator to handle libraries like 'showcase' that require multiple include paths for protoc. Additionally, several variables and parameters previously named googleapisDir were renamed to more generic terms like protoSourceDir or sourceDir to reflect their broader usage. Feedback indicates that the resolveGAPICOptions function definition should also be updated to use the new naming convention for consistency.
sofisl
reviewed
May 4, 2026
sofisl
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support showcase as source in generate, pass both showcase dir and googleapis dir to protoc via -I flags, use only showcase dir for copy protos, and finding service configs. Also renaming variables related to googleapisDir for clarity.
For #5731