fix(legacylibrarian): restore chore as noop#5811
Merged
noahdietz merged 9 commits intoMay 6, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the versioning logic in NextVersion to prevent unnecessary minor version bumps in releaseOnlyMode when no releasable changes are present. Specifically, it adds a check for highestChange != semver.None and updates associated tests to reflect that chore commits no longer trigger bumps in this mode. Feedback suggests simplifying the logic by removing a redundant length check and restoring documentation for the non-obvious versioning behavior.
…er.go Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Noah Dietz <noahdietz@users.noreply.github.com>
sofisl
previously approved these changes
May 5, 2026
Contributor
|
Doesn't this mean that no librarian generation PRs will trigger a release? Or is the intention that Librarian PRs will now have a "feat" commit? |
Contributor
Author
Contributor
Contributor
Author
Signed-off-by: Noah Dietz <noahdietz@users.noreply.github.com>
jskeet
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores previous
legacylibrarianbehavior that would allowchorecommits (which map to asemver.ChangeLevelofsemver.None) through as "no-op" changes. After this, a library with onlychorecommits will not be considered eligible for release. More background/details in #5786.Updates
librarianops generateto produce afeatcommit. Corresponding playbook updates will follow.Fixes #5786