fix(internal/librarian/java): install to use config.Tools instead of embedded librarian.yaml#6157
Merged
Merged
Conversation
…ng to embedded yaml
…embedded librariayn.yaml
rm extra line
zhumin8
force-pushed
the
fix-install-migrate
branch
from
497c514 to
74dc412
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the Java tool installation logic to accept configuration tools as a parameter rather than relying on an embedded YAML file within the java package. The responsibility for providing the tool configuration has been shifted to the caller, specifically within the migration tool where the YAML is now embedded and unmarshaled. Additionally, the protoc-gen-grpc-java version has been updated to 1.81.0 across the codebase and tests, and the migration tests have been refactored for better maintainability. I have no feedback to provide.
JoeWang1127
reviewed
May 23, 2026
JoeWang1127
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor Java install to used config.Tools from librarian.yaml from language repo instead of embedded librarian.yaml. Use embedded librarian.yaml instead in migrate tool to populate librarian.yaml tools section.
Also updated protoc-gen-grpc-java version to 1.81.0 to match version used in google-cloud-java hermetic build.
Fixes #6155