feat: Add micro-benchmarks for writes comparing standard (regional) vs rapid (zonal) buckets. #1707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e analysis - Adjusted file size and rounds in config.yaml for better benchmarking accuracy. - Enhanced download object tests in test_reads.py to include random chunk downloading. - Refactored upload and download worker functions for improved clarity and performance.
…ersisted_size_sync to accept command-line arguments
…ve CRC32 performance measurement
…ects in Google Cloud Storage
- Introduced RandomBytesIO for generating random bytes on-the-fly, reducing memory usage during uploads. - Updated upload logic in test_writes.py to utilize RandomBytesIO instead of os.urandom. - Adjusted download logic in test_reads.py to correctly handle byte ranges. - Cleaned up config.py and conftest.py by removing commented-out code and unnecessary lines. - Minor adjustments in config_writes.yaml for clarity.
…ity and remove unused import in test_writes
chandra-siri
changed the title
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Collaborator
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a micro-benchmarking suite for GCS writes, comparing regional (JSON) and zonal (gRPC) buckets under various concurrency scenarios. The overall structure is well-organized, with separate files for configuration, parameters, and tests. My review focuses on improving the correctness of the benchmark measurements, enhancing code clarity and maintainability, and adhering to Python best practices. Key suggestions include optimizing the data generation process within the benchmark loop to prevent skewed results, improving docstrings for better readability, and refactoring for clearer code.
…its purpose and usage
jasha26
previously approved these changes
Jan 21, 2026
Pulkit0110
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.