Skip to content

Use upstream vs2022 support#94

Merged
ifratric merged 2 commits intogoogleprojectzero:masterfrom
theKidOfArcrania:master
Mar 4, 2026
Merged

Use upstream vs2022 support#94
ifratric merged 2 commits intogoogleprojectzero:masterfrom
theKidOfArcrania:master

Conversation

@theKidOfArcrania
Copy link
Contributor

Remove workaround by using the upstream mbuild support instead of a workaround (that doesn't work sometimes?)

@google-cla
Copy link

google-cla bot commented Mar 2, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ifratric
Copy link
Collaborator

ifratric commented Mar 3, 2026

Hey, thanks for the PR! Does third_party/xed also need to be updated in addition to mbuild (would be nice to do update at the same time unless there is some incompatibility). Also, as the bot said, I can't merge a pull request until you sign a CLA.

@theKidOfArcrania
Copy link
Contributor Author

I did the min required update to support msvc 2022 (i.e. only updating mbuild up to the needed version). I don't think we need to update xed (at least it build fine on my end).

@ifratric ifratric merged commit 6ce405b into googleprojectzero:master Mar 4, 2026
1 check passed
@ifratric
Copy link
Collaborator

ifratric commented Mar 4, 2026

Thanks! I'm merging now, but I should update both xed and mbuild to the latest version sometime in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants