Skip to content

fix(nix): use host platform for system dependencies - #966

Closed
Eotel wants to merge 1 commit into
googleworkspace:mainfrom
Eotel:fix/nix-stdenv-host-platform
Closed

Eotel wants to merge 1 commit into
googleworkspace:mainfrom
Eotel:fix/nix-stdenv-host-platform

Conversation

@Eotel

@Eotel Eotel commented Oct 26, 2026 •

Copy link
Copy Markdown

Summary

- pkgs.stdenv.isLinux / pkgs.stdenv.isDarwin
+ pkgs.stdenv.hostPlatform.isLinux / pkgs.stdenv.hostPlatform.isDarwin

Selects the same system dependencies through the supported Nixpkgs platform attributes. Includes a patch changeset.

Evidence

  • Before: Evaluating the macOS gws derivation emitted deprecation warnings for both stdenv.isLinux and stdenv.isDarwin.
  • After: The macOS and Linux gws derivations both evaluate without those warnings using the current Nixpkgs input from a downstream configuration.

Merge Danger

Door: Two-way

Blast Radius: Nix package evaluation on Linux and macOS. The selected dependency lists remain the same.

@changeset-bot

changeset-bot Bot commented Oct 26, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a064585

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@googleworkspace/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-cla

google-cla Bot commented Oct 26, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions

Copy link
Copy Markdown
Contributor

This PR has been inactive for 72 hours. Closing to keep the queue clean.

@github-actions github-actions Bot added the Stale label Oct 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR was closed because it has been stalled for 72 hours. Feel free to magically reopen it if you want to continue working on it!

@github-actions github-actions Bot closed this Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant