Skip to content

chore: upgrade v1.17#57

Merged
hwbrzzl merged 1 commit intomasterfrom
bowen/upgrade-v1.17
Jan 30, 2026
Merged

chore: upgrade v1.17#57
hwbrzzl merged 1 commit intomasterfrom
bowen/upgrade-v1.17

Conversation

@hwbrzzl
Copy link
Copy Markdown
Contributor

@hwbrzzl hwbrzzl commented Jan 30, 2026

📑 Description

@coderabbitai summary

✅ Checks

  • Added test cases for my code

Copilot AI review requested due to automatic review settings January 30, 2026 09:06
@hwbrzzl hwbrzzl requested a review from a team as a code owner January 30, 2026 09:06
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 30, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Process dependency is propagated into Docker and SQL Server initialization: Docker gains a process field and constructor parameter; SQL Server accepts and stores a process and validates it before creating Docker resources; tests and image driver creation are updated to pass the process through.

Changes

Cohort / File(s) Summary
Docker Container Setup
docker.go, docker_test.go
Added process contractsprocess.Process field to Docker, changed NewDocker signature to accept process, stored it on the struct, passed process into image driver creation and tests updated to pass process.New() to constructor.
SQL Server Integration
service_provider.go, sqlserver.go
Updated NewSqlserver signature to accept process and added process field to Sqlserver. Docker() now checks for non-nil process and passes it into NewDocker. service_provider.go call updated to app.MakeProcess().
Image Driver
...testingdocker.NewImageDriver(...) usages
Image driver creation calls now include the process parameter (e.g., testingdocker.NewImageDriver(image, r.process)).
Module dependencies
go.mod
Bumped goravel/framework pseudo-version and refreshed indirect dependencies (Charmbracelet modules, muesli, updated x/* packages, grpc v1.78.0, mapstructure/v2 v2.5.0, etc.).

Sequence Diagram(s)

sequenceDiagram
    participant SP as ServiceProvider
    participant AppProc as App Process (app.MakeProcess)
    participant Sql as Sqlserver
    participant Docker as Docker
    participant Image as ImageDriver

    SP->>AppProc: request process
    AppProc-->>SP: process instance
    SP->>Sql: NewSqlserver(config, log, process, conn)
    Sql->>Sql: store process
    Sql->>Docker: Docker() // create container
    Docker->>Docker: validate process != nil
    Docker->>Image: NewImageDriver(image, process)
    Image-->>Docker: image driver with process
    Docker-->>Sql: return container handle
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bowen/upgrade-v1.17

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@hwbrzzl hwbrzzl merged commit 2a734bd into master Jan 30, 2026
9 of 10 checks passed
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the sqlserver driver to align with the newer Goravel framework version by wiring in the Process facade where required for Docker-based testing utilities.

Changes:

  • Bumped github.com/goravel/framework dependency and refreshed transitive module versions (go.mod / go.sum).
  • Injected process.Process into Sqlserver and Docker so Docker image/container helpers can use the framework process implementation.
  • Updated the service provider and Docker test suite to supply the Process dependency.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
sqlserver.go Adds process.Process to the driver and passes it through when constructing Docker driver.
service_provider.go Updates driver construction to pass app.MakeProcess().
docker.go Extends Docker driver to carry/process-inject contracts/process.Process into image driver creation.
docker_test.go Updates tests to pass a concrete framework process implementation.
go.mod Upgrades framework version and refreshes indirect dependencies.
go.sum Updates module checksums to match the upgraded dependency graph.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants