test: cover feedback labels#11
Open
zhangzhenghao wants to merge 1 commit into
Open
Conversation
zhangzhenghao
force-pushed
the
test-feedback-labels
branch
from
bdb6463 to
ade3906
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- add labels to part of the feedbacks inserted in sync and async feedback tests\n- keep the existing list_feedbacks assertions to verify labeled feedback inserts successfully participate in feedback queries\n\n## Tests\n- PYTHONDONTWRITEBYTECODE=1 python3 -m py_compile tests/test_gorse.py\n- git diff --check\n\nNote: the failed CI run showed list_feedbacks in the test service response does not include Labels, so this PR verifies insertion of labeled feedback without asserting returned Labels.