fix: hide delete overlay for default app images #873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #873 +/- ##
=======================================
Coverage 79.14% 79.14%
=======================================
Files 56 56
Lines 2225 2225
=======================================
Hits 1761 1761
Misses 360 360
Partials 104 104 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jmattheis
reviewed
Nov 16, 2025
| <TableCell padding="normal"> | ||
| <div style={{display: 'flex'}}> | ||
| <Tooltip title="Delete image" placement="top" arrow> | ||
| <ButtonBase className={classes.imageContainer} onClick={fDeleteImage}> |
Member
There was a problem hiding this comment.
The Button can be disabled instead of removing the ToolTip/ButtonBase when the image doesn't exists.
jmattheis
force-pushed
the
fix-default-image-delete
branch
from
3c39d98 to
9019710
Compare
jmattheis
force-pushed
the
fix-default-image-delete
branch
from
9019710 to
883cc15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst looking at #872 I found the ability to delete default app images to be confusing.
This PR simply adds a check if the image starts with
image/which is different from the default which isstatic/. if false do not render the tooltip and the button which ultimately if rendered / used results in an error if clicked / go through the 2 step process.before:
Screencast_20251106_091748.webm
after:
Screencast_20251106_091930.webm