feat and bug-fix - The previous implementation StructMessageHandler did not correctly handle the google.protobuf.XYZ types #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r did not correctly handle the fields This MR provides the implementation for the below "message" types google.protobuf.Struct, google.protobuf.Value, google.protobuf.ListValue, and google.protobuf.NullValue Adds GoogleProtobufComplexMessageHandler to handle some of the complex Google Protobuf message types that are dynamic and recursive in nature. This implementation converts these message types to Protobuf's byte-array representation. While outputting the data, the byte array is converted back to the original structure using the associated field descriptor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR provides the implementation for the below "message" types
google.protobuf.Struct,
google.protobuf.Value,
google.protobuf.ListValue, and
google.protobuf.NullValue
Adds GoogleProtobufComplexMessageHandler to handle some of the complex Google Protobuf message types that are dynamic and recursive in nature.
This implementation converts these message types to Protobuf's byte-array representation.
While outputting the data, the byte array is converted back to the original structure using the associated field descriptor.