feat(commonlib): Move style choices to design tokens dir #1516
Conversation
Making eaier to manage those choices and override those in the future in one place.
Remove misleading thresholds from grafana by default
Dasomeone
left a comment
Dasomeone
left a comment
There was a problem hiding this comment.
This is a fantastic effort @v-zhuravlev! Works great too, tested with the kafka observ-lib locally, and worked just fine and added additional palette info to a couple panels.
One comment on consistent naming on colours, what gets aliases and what doesn't, but overall hugely in favour of this.
| + timeSeries.standardOptions.color.withMode('fixed') | ||
| + timeSeries.standardOptions.color.withFixedColor('light-purple'), | ||
| + timeSeries.standardOptions.color.withMode(tokens.base.colors.mode.single) | ||
| + timeSeries.standardOptions.color.withFixedColor(tokens.base.colors.palette['light-purple']), |
There was a problem hiding this comment.
Given that this particular colour has an alias for rate but nor for topk_percentage, perhaps we should settle on a consistent approach here?
There was a problem hiding this comment.
wdyt, what should be done here?
There was a problem hiding this comment.
I think in this particular case it's fine to just create a second alias for like default_topk or similar, and have that be the same light-purple? :)
There was a problem hiding this comment.
actually, it was a alias there already - 'threshold'! changing it to this style, as here it is applied not to topk values themselves, but to dotted threshols line that represents MEAN of values.
There was a problem hiding this comment.
@Dasomeone , please let me know if there is something else that should be done , thanks!
2 participants
Making easier to manage those choices and override those in the future in one place.
In other words, all things like colors or line thickness are placed in in folder, and then referenced by commonlib panels (or observ-libs that uses common-lib as a core). So if it decided to change base colors used it just one place where to change it.
Refs
https://www.uxpin.com/studio/blog/what-are-design-tokens/
Meantime, this is not a breaking change, everything should work as before.