chore: Apache HBase modernization #1537

schmikei · 2025-11-06T19:38:22Z

This PR modernizes the Apache HBase mixin to use commonlib and g.libsonnet to generate its dashboards. This will make future stylizations easier to accomplish :)

Feel free to use this PR to generate a Sample environment: grafana/integration-sample-apps#102
Cluster Overview:

RegionServer Overview:

Logs:

…pache-hbase-modernization

Dasomeone

One teensy comment from my end, otherwise looks fantastic!

apache-hbase-mixin/config.libsonnet

aalhour

I have a few requests for changes, below is a summary:

Do we want to add {%(filteringSelector)s} to the alerts below?
There are a few raw signals in regionserver and cluster files that we might want to change to counter type with a rangeFunction: 'rate' or convert the query to rate(...), or increase(...).
There is a counter metric (totalRequestRate) that might want a rangeFunction: 'rate' added to it
I noticed that the masterQueueSize metric has a weird unit ('decbytes') but it's a number (total items in a queue), shouldn't it be short?
There are a few duplicate signals between regionserver and cluster files with the same key, metric but slightly different queries (outlined below)

aalhour · 2025-11-25T14:31:13Z

apache-hbase-mixin/alerts.libsonnet

          {
            alert: 'HBaseDeadRegionServer',
            expr: |||
              server_num_dead_region_servers > %(alertsDeadRegionServer)s


Should this use the filteringSelector?

aalhour · 2025-11-25T14:31:28Z

apache-hbase-mixin/alerts.libsonnet

          {
            alert: 'HBaseOldRegionsInTransition',
            expr: |||
              100 * assignment_manager_rit_count_over_threshold / clamp_min(assignment_manager_rit_count, 1) > %(alertsOldRegionsInTransition)s


Should this use the filteringSelector?

aalhour · 2025-11-25T14:31:41Z

apache-hbase-mixin/alerts.libsonnet

          {
            alert: 'HBaseHighMasterAuthFailRate',
            expr: |||
              100 * rate(master_authentication_failures[5m]) / (clamp_min(rate(master_authentication_successes[5m]), 1) + clamp_min(rate(master_authentication_failures[5m]), 1)) > %(alertsHighMasterAuthFailRate)s


Should this use the filteringSelector?

aalhour · 2025-11-25T14:32:07Z

apache-hbase-mixin/alerts.libsonnet

          {
            alert: 'HBaseHighRSAuthFailRate',
            expr: |||
              100 * rate(region_server_authentication_failures[5m]) / (clamp_min(rate(region_server_authentication_successes[5m]), 1) + clamp_min(rate(region_server_authentication_failures[5m]), 1)) > %(alertsHighRSAuthFailRate)s


Should this use the filteringSelector?

aalhour · 2025-11-25T14:40:43Z

apache-hbase-mixin/signals/cluster.libsonnet

+        unit: 'reqps',
+        sources: {
+          prometheus: {
+            expr: 'sum by(' + groupAggList + ') (master_authentication_successes{%(queriesSelector)s})',


Example: This signal reads as "Rate of ..." but the query doesn't use the rate(...) function, which most likely will lead them to be displayed as as raw counter values instead of rates.

aalhour · 2025-11-25T14:50:08Z

apache-hbase-mixin/signals/regionserver.libsonnet

+        unit: 'reqps',
+        sources: {
+          prometheus: {
+            expr: 'sum by(' + groupAggList + ') (rate(region_server_authentication_successes{%(queriesSelector)s}[$__rate_interval]))',


This is a raw metric that uses a rate function correctly but it's also a duplicate of the same signal and same metric in cluster.libsonnet file but that one doesn't use the rate function as this one. Can we remove it from the clusters signals?

aalhour · 2025-11-25T14:50:35Z

apache-hbase-mixin/signals/cluster.libsonnet

+        unit: 'reqps',
+        sources: {
+          prometheus: {
+            expr: 'sum by(' + groupAggList + ') (region_server_authentication_successes{%(queriesSelector)s})',


Duplicate of the same signal with the same metric (but different query) in regionserver.libsonnet: https://github.com/grafana/jsonnet-libs/pull/1537/files#r2560283881

aalhour · 2025-11-25T14:50:59Z

apache-hbase-mixin/signals/cluster.libsonnet

+        unit: 'reqps',
+        sources: {
+          prometheus: {
+            expr: 'sum by(' + groupAggList + ') (region_server_authentication_failures{%(queriesSelector)s})',


Another duplicate of the same signal in regionserver.libsonnet file.

aalhour · 2025-11-25T14:51:42Z

apache-hbase-mixin/signals/regionserver.libsonnet

+        unit: 'reqps',
+        sources: {
+          prometheus: {
+            expr: 'sum by(' + groupAggList + ') (rate(region_server_authentication_failures{%(queriesSelector)s}[$__rate_interval]))',


This is a correct raw signal that uses a rate function but it's a duplicate of another one in cluster.libsonnet, can we remove the other one from the cluster signals file?

aalhour · 2025-11-25T14:53:50Z

apache-hbase-mixin/panels.libsonnet

+            g.panel.table.standardOptions.withLinks([
+              {
+                title: '',
+                url: '/d/apachehbase-regionserver-overview?from=${__from}&to=${__to}&var-instance=${__data.fields["RegionServer"]}',


Is there a way to use the links from links.libsonnet?

…pache-hbase-modernization

Dasomeone

One last little thing in addition to @aalhour's review. Would also be good if we can get the existing comment threads resolved (even if they already are)

Dasomeone · 2025-12-15T15:36:46Z

apache-hbase-mixin/signals/cluster.libsonnet

+        name: 'Master queue size',
+        type: 'gauge',
+        description: 'The size of the queue of requests, operations, and tasks to be processed by the master.',
+        unit: 'decbytes',


Correct, it's number of items in queue, and if we want to display actual byte size we need to multiple by the block size.

I think @aalhour is correct that the original intent was to use just number of items in queue since blocksize is configurable based on file system. Let's switch this to short

…pache-hbase-modernization

Dasomeone · 2025-12-17T13:54:00Z

apache-hbase-mixin/config.libsonnet

 {
  local this = self,
-  filteringSelector: 'job="integrations/apache-hbase"',
+  filteringSelector: 'job=~".+"',  // set to apply static filters to all queries and alerts, i.e. job="bar"


If you pull latest logs-lib into the vendor, you should be able to get away with just an empty string here, but this is fine too :)

Dasomeone

Teensy tiny comment on the vendoring, otherwise good to go! Looks great, thanks!

…pache-hbase-modernization

schmikei added 2 commits November 6, 2025 14:35

modernize the hbase mixin

4aef755

Merge branch 'master' of github.com:grafana/jsonnet-libs into chore/a…

8f982c5

…pache-hbase-modernization

schmikei marked this pull request as ready for review November 6, 2025 19:50

schmikei requested a review from a team as a code owner November 6, 2025 19:50

schmikei added the monitoring-mixins label Nov 6, 2025

Dasomeone reviewed Nov 14, 2025

View reviewed changes

apache-hbase-mixin/config.libsonnet Outdated Show resolved Hide resolved

remove prometheusv2 from config.libsonnet

d9f61a3

Dasomeone approved these changes Nov 14, 2025

View reviewed changes

aalhour requested changes Nov 25, 2025

View reviewed changes

schmikei added 3 commits November 26, 2025 16:08

pr feedback

13c0386

make lint

b96a680

Merge branch 'master' of github.com:grafana/jsonnet-libs into chore/a…

9a53be1

…pache-hbase-modernization

Dasomeone assigned aalhour and Dasomeone Dec 4, 2025

aalhour approved these changes Dec 9, 2025

View reviewed changes

schmikei enabled auto-merge (squash) December 11, 2025 16:18

Dasomeone reviewed Dec 15, 2025

View reviewed changes

schmikei disabled auto-merge December 16, 2025 20:24

schmikei added 6 commits December 16, 2025 15:27

udpate unit for master_queue_size => short

e7571b6

Merge branch 'master' of github.com:grafana/jsonnet-libs into chore/a…

fc9b419

…pache-hbase-modernization

remove filteringSelector based off recent feedback

c969887

withIncludeVars(true)

84b52db

running into issues with filteringSelector being blank

2f833fc

make fmt

f74aec6

Dasomeone reviewed Dec 17, 2025

View reviewed changes

Dasomeone approved these changes Dec 17, 2025

View reviewed changes

schmikei added 2 commits December 17, 2025 09:13

Merge branch 'master' of github.com:grafana/jsonnet-libs into chore/a…

cf85e15

…pache-hbase-modernization

merge from main; re-build the mixin

7e1d1ae

schmikei merged commit a4f2a73 into grafana:master Dec 17, 2025
11 checks passed

schmikei deleted the chore/apache-hbase-modernization branch December 17, 2025 15:26

chore: Apache HBase modernization #1537

chore: Apache HBase modernization #1537

Uh oh!

Conversation

schmikei commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Dasomeone left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aalhour left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Dasomeone left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Dasomeone left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

schmikei commented Nov 6, 2025 •

edited

Loading