-
Notifications
You must be signed in to change notification settings - Fork 177
chore: IIS Modernization #1542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
chore: IIS Modernization #1542
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ff24338
modernize the iis mxin
schmikei 4a7abc8
make dashboards_out
schmikei e799266
fix lint
schmikei bc6fa71
use commonlib a tad bit more for panels
schmikei b277df4
PR feedback/good catches on missing panels on the overview dashboard
schmikei 1011feb
modify config.libsonnet to be more easily understandable that its an …
schmikei a132012
fix description after alert change
schmikei bd42d17
Merge branch 'master' into chore/iis-modernization
schmikei 809972f
remove filteringSelector from public mixin; withKeepVars; increase wi…
schmikei 007db5f
Merge branch 'master' into chore/iis-modernization
Dasomeone File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| { | ||
| new(this): { | ||
| groups: [ | ||
| { | ||
| name: 'MicrosoftIISAlerts', | ||
| rules: [ | ||
| { | ||
| alert: 'MicrosoftIISRejectedAsyncIORequests', | ||
| expr: ||| | ||
| increase(windows_iis_rejected_async_io_requests_total{%(filteringSelector)s}[5m]) > %(alertsWarningHighRejectedAsyncIORequests)s | ||
| ||| % this.config, | ||
| 'for': '5m', | ||
| labels: { | ||
| severity: 'warning', | ||
| }, | ||
| annotations: { | ||
| summary: 'There are a high number of rejected async I/O requests for a site.', | ||
| description: | ||
| ('The number of rejected async IO requests is {{ printf "%%.0f" $value }} over the last 5m on {{ $labels.instance }} - {{ $labels.site }}, ' + | ||
| 'which is above the threshold of %(alertsWarningHighRejectedAsyncIORequests)s.') % this.config, | ||
| }, | ||
| }, | ||
| { | ||
| alert: 'MicrosoftIIS5xxRequestErrors', | ||
| expr: ||| | ||
| sum without (pid, status_code)(increase(windows_iis_worker_request_errors_total{status_code=~"5.."%(filteringSelector)s}[5m])) > %(alertsCriticalHigh5xxRequests)s | ||
| ||| % (this.config { filteringSelector: if this.config.filteringSelector != '' then ',' + this.config.filteringSelector else '' }), | ||
| 'for': '5m', | ||
| labels: { | ||
| severity: 'critical', | ||
| }, | ||
| annotations: { | ||
| summary: 'There are a high number of 5xx request errors for an application.', | ||
| description: | ||
| ('The number of 5xx request errors is {{ printf "%%.0f" $value }} over the last 5m on {{ $labels.instance }} - {{ $labels.app }}, ' + | ||
| 'which is above the threshold of %(alertsCriticalHigh5xxRequests)s.') % this.config, | ||
| }, | ||
| }, | ||
| { | ||
| alert: 'MicrosoftIISSuccessRateForWebsocket', | ||
| expr: ||| | ||
| sum without (pid) (increase(windows_iis_worker_websocket_connection_accepted_total{%(filteringSelector)s}[5m]) / clamp_min(increase(windows_iis_worker_websocket_connection_attempts_total{%(filteringSelector)s}[5m]),1)) * 100 < %(alertsCriticalLowWebsocketConnectionSuccessRate)s | ||
| ||| % this.config, | ||
| 'for': '5m', | ||
| labels: { | ||
| severity: 'critical', | ||
| }, | ||
| annotations: { | ||
| summary: 'There is a low success rate for websocket connections for an application.', | ||
| description: | ||
| ('The success rate for websocket connections is {{ printf "%%.0f" $value }} over the last 5m on {{ $labels.instance }} - {{ $labels.app }}, ' + | ||
| 'which is below the threshold of %(alertsCriticalLowWebsocketConnectionSuccessRate)s.') % this.config, | ||
| }, | ||
| }, | ||
| { | ||
| alert: 'MicrosoftIISThreadpoolUtilization', | ||
| expr: ||| | ||
| sum without (pid, state)(windows_iis_worker_threads{%(filteringSelector)s} / windows_iis_worker_max_threads{%(filteringSelector)s}) * 100 > %(alertsCriticalHighThreadPoolUtilization)s | ||
| ||| % this.config, | ||
| 'for': '5m', | ||
| labels: { | ||
| severity: 'critical', | ||
| }, | ||
| annotations: { | ||
| summary: 'The thread pool utilization is nearing max capacity.', | ||
| description: | ||
| ('The threadpool utilization is at {{ printf "%%.0f" $value }} over the last 5m on {{ $labels.instance }} - {{ $labels.app }}, ' + | ||
| 'which is above the threshold of %(alertsCriticalHighThreadPoolUtilization)s.') % this.config, | ||
| }, | ||
| }, | ||
| { | ||
| alert: 'MicrosoftIISWorkerProcessFailures', | ||
| expr: ||| | ||
| increase(windows_iis_total_worker_process_failures{%(filteringSelector)s}[5m]) > %(alertsWarningHighWorkerProcessFailures)s | ||
| ||| % this.config, | ||
| 'for': '5m', | ||
| labels: { | ||
| severity: 'warning', | ||
| }, | ||
| annotations: { | ||
| summary: 'There are a high number of worker process failures for an application.', | ||
| description: | ||
| ('The number of worker process failures is at {{ printf "%%.0f" $value }} over the last 5m on {{ $labels.instance }} - {{ $labels.app }}, ' + | ||
| 'which is above the threshold of %(alertsWarningHighWorkerProcessFailures)s.') % this.config, | ||
| }, | ||
| }, | ||
| ], | ||
| }, | ||
| ], | ||
| }, | ||
| } |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,38 @@ | ||
| { | ||
| _config+:: { | ||
| dashboardTags: ['microsoft-iis-mixin'], | ||
| dashboardPeriod: 'now-1h', | ||
| dashboardTimezone: 'default', | ||
| dashboardRefresh: '1m', | ||
| local this = self, | ||
| filteringSelector: '', // set to apply static filters to all queries and alerts, i.e. job="bar" | ||
| groupLabels: ['job'], | ||
| instanceLabels: ['instance'], | ||
| logLabels: ['job', 'instance'], | ||
|
|
||
| // alerts thresholds | ||
| alertsWarningHighRejectedAsyncIORequests: 20, | ||
| alertsCriticalHigh5xxRequests: 5, | ||
| alertsCriticalLowWebsocketConnectionSuccessRate: 80, | ||
| alertsCriticalHighThreadPoolUtilization: 90, | ||
| alertsWarningHighWorkerProcessFailures: 10, | ||
|
|
||
| enableLokiLogs: true, | ||
| // Dashboard settings | ||
| dashboardTags: [this.uid + '-mixin'], | ||
| uid: 'microsoft-iis', | ||
| dashboardNamePrefix: 'Microsoft IIS', | ||
| dashboardPeriod: 'now-30m', | ||
| dashboardTimezone: 'default', | ||
| dashboardRefresh: '1m', | ||
|
|
||
| // Logs configuration | ||
| enableLokiLogs: true, | ||
| extraLogLabels: ['level'], // Required by logs-lib | ||
| logsVolumeGroupBy: 'level', | ||
| showLogsVolume: true, | ||
|
|
||
| // Alert thresholds | ||
| alertsWarningHighRejectedAsyncIORequests: 20, // count | ||
| alertsCriticalHigh5xxRequests: 5, // % | ||
| alertsCriticalLowWebsocketConnectionSuccessRate: 80, // % | ||
| alertsCriticalHighThreadPoolUtilization: 90, // % | ||
| alertsWarningHighWorkerProcessFailures: 10, // count | ||
|
|
||
| // Metrics source | ||
| metricsSource: ['prometheus'], | ||
|
|
||
| // Signal definitions grouped by dashboard | ||
| signals+: { | ||
| overview: (import './signals/overview.libsonnet')(this), | ||
| applications: (import './signals/applications.libsonnet')(this), | ||
| }, | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do all or some of the alerts need to use the
{%(filteringSelector)s}? It's not present in any of them.