-
Notifications
You must be signed in to change notification settings - Fork 176
chore: Modernize the MongoDB Atlas Mixin #1544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,45 @@ | ||
| { | ||
| _config+:: { | ||
| // sharding dashboard flag | ||
| enableShardingOverview: false, | ||
| local this = self, | ||
|
|
||
| dashboardTags: ['mongodb-atlas-mixin'], | ||
| dashboardPeriod: 'now-30m', | ||
| dashboardTimezone: 'default', | ||
| dashboardRefresh: '1m', | ||
| // Basic filtering - MongoDB Atlas uses job and cl_name (cluster name) as primary filters | ||
| filteringSelector: 'job="integrations/mongodb-atlas"', | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As we've recently talked about, we can vendor latest logs-lib and unset this for the public mixin |
||
| groupLabels: ['job', 'cl_name'], | ||
| instanceLabels: ['instance'], | ||
|
|
||
| // alerts thresholds | ||
| alertsDeadlocks: 10, // count | ||
| alertsSlowNetworkRequests: 10, // count | ||
| alertsHighDiskUsage: 90, // percentage: 0-100 | ||
| alertsSlowHardwareIO: 3, // seconds | ||
| alertsHighTimeoutElections: 10, // count | ||
| // Dashboard settings | ||
| dashboardTags: ['mongodb-atlas-mixin'], | ||
| uid: 'mongodb-atlas', | ||
| dashboardNamePrefix: 'MongoDB Atlas', | ||
| dashboardRefresh: '1m', | ||
| dashboardPeriod: 'now-30m', | ||
| dashboardTimezone: 'default', | ||
|
|
||
| // Sharding dashboard flag, enable this to generate the sharding overview dashboard | ||
| enableShardingOverview: true, | ||
|
|
||
| // Logs configuration (MongoDB Atlas does not have Loki logs by default) | ||
| enableLokiLogs: false, // note for users, this is not supported by the MongoDB Atlas mixin as there shouldn't be any logs to monitor yet | ||
| logLabels: [], | ||
| extraLogLabels: [], | ||
| logsVolumeGroupBy: 'level', | ||
| showLogsVolume: false, | ||
|
|
||
| // Alert thresholds with units | ||
| alertsDeadlocks: 10, // count | ||
| alertsSlowNetworkRequests: 10, // count | ||
| alertsHighDiskUsage: 90, // % | ||
| alertsSlowHardwareIO: 3, // seconds | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Like I commented on a previous PR, we could consider having the units be more tightly coupled with the native metric unit, e.g. milliseconds in order to simplify the query |
||
| alertsHighTimeoutElections: 10, // count | ||
|
|
||
| // Metrics source | ||
| metricsSource: 'prometheus', | ||
|
|
||
| // Import signal definitions (organized by dashboard) | ||
| signals+: { | ||
| cluster: (import './signals/cluster.libsonnet')(this), | ||
| elections: (import './signals/elections.libsonnet')(this), | ||
| operations: (import './signals/operations.libsonnet')(this), | ||
| performance: (import './signals/performance.libsonnet')(this), | ||
| sharding: (import './signals/sharding.libsonnet')(this), | ||
| }, | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like I commented on a previous PR, we could consider having the units be more tightly coupled with the native metric unit, e.g. milliseconds in order to simplify the query