Add two SNMPinterfacedown alerts with different severities #1569
+47
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dasomeone
approved these changes
Dec 18, 2025
Member
There was a problem hiding this comment.
Nicely done, thanks @v-zhuravlev !
Edit: Oop, looks like linting fails, missing bracket close!
prometheus_rules_out/prometheus_alerts.yaml:88-91 Fatal: Prometheus failed to parse the query with this PromQL error: error parsing regexp: missing closing ): `.*(?i:(critical).*`. (promql/syntax)```
Contributor
Author
|
fixed |
Member
@v-zhuravlev still failing linting unfortunately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make snmp-observ-lib more versatile, this adds two SNMPinterfacedown alerts with different severities: warning and critical instead of just one.
Deprecate old selector but map it to alertInterfaceDownSelectorWarning so it still works with previous default severity.