Skip to content

Clean up redundant ImageSharp references, document the elFinder HTTP pin #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KrzysztofPajak merged 2 commits into from
Aug 8, 2026
Merged

Clean up redundant ImageSharp references, document the elFinder HTTP pin #763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad851dd
Document why AdminShared pins Microsoft.AspNetCore.Http
KrzysztofPajak Aug 8, 2026
29769bd
Remove redundant direct SixLabors.ImageSharp references
KrzysztofPajak Aug 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
<PackageVersion Include="AWSSDK.Core" Version="4.0.100.9" />
<PackageVersion Include="AWSSDK.S3" Version="4.0.101.5" />
<PackageVersion Include="Azure.Storage.Blobs" Version="12.29.1" />
<PackageVersion Include="SixLabors.ImageSharp" Version="3.1.12" />
<PackageVersion Include="SkiaSharp" Version="4.150.1" />
<PackageVersion Include="SkiaSharp.NativeAssets.Linux.NoDependencies" Version="4.150.1" />
<PackageVersion Include="LiteDB" Version="5.0.21" />
Expand Down
1 change: 0 additions & 1 deletion src/Business/Grand.Business.Common/Grand.Business.Common.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
<Import Project="..\..\Build\Grand.Common.props" />
<ItemGroup>
<PackageReference Include="ExcelMapper" />
<PackageReference Include="SixLabors.ImageSharp" />
<PackageReference Include="Scryber.Core" />
<PackageReference Include="Scryber.Core.OpenType" />
<PackageReference Include="System.Security.Cryptography.Xml" />
Expand Down
1 change: 0 additions & 1 deletion src/Web/Grand.Web.Admin/Grand.Web.Admin.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
<PackageReference Include="elFinder.Net.AspNetCore" />
<PackageReference Include="elFinder.Net.Core" />
<PackageReference Include="elFinder.Net.Drivers.FileSystem" />
<PackageReference Include="SixLabors.ImageSharp" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\..\Aspire\Aspire.ServiceDefaults\Aspire.ServiceDefaults.csproj" />
Expand Down
4 changes: 3 additions & 1 deletion src/Web/Grand.Web.AdminShared/Grand.Web.AdminShared.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@
<PackageReference Include="elFinder.Net.AspNetCore" />
<PackageReference Include="elFinder.Net.Core" />
<PackageReference Include="elFinder.Net.Drivers.FileSystem" />
<!-- Not used in code. elFinder.Net.* 1.5.0 drags in the ASP.NET Core 2.1.x graph, and its
Microsoft.AspNetCore.Http 2.1.1 has a known high severity advisory (GHSA-hxrm-9w7p-39cc).
This reference lifts it to a patched 2.x. Remove only together with elFinder. -->
<PackageReference Include="Microsoft.AspNetCore.Http" />
<PackageReference Include="SixLabors.ImageSharp" />
</ItemGroup>
</Project>
Loading