Take the admin theme switch out of the store panel - #775
Merged
Conversation
The admin theme selection drives the panel chrome for everyone, so a store owner saving general settings should not be able to flip it. Drop the input from the store information tab and preserve the stored value across the save. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the Allow to select admin theme option from the store panel's general settings (Store information tab) in
Grand.Web.Store.StoreInformationSettings.AllowToSelectAdminThemeinput fromAreas/Store/Views/Setting/Partials/GeneralCommon.TabStoreInformationSettings.cshtml.SettingController.GeneralCommon(POST) snapshots the stored value beforeToEntityand restores it after, so saving the tab no longer writesfalseinto the store scope from the now-missing form field.Why
The flag drives
StoreThemeContext/AdminThemeContext— panel chrome rather than storefront content — so it is admin-managed. This follows the preserve/restore lock pattern already used for the media file-manager fields in the same controller. The option stays fully manageable inGrand.Web.Admin.Testing
dotnet build src/Web/Grand.Web.Store/Grand.Web.Store.csproj— succeeded, 0 warnings, 0 errors.🤖 Generated with Claude Code