Skip to content

fix(gfql): preserve entity metadata across multi-alias bindings - #2350

Draft
lmeyerov wants to merge 4 commits into
masterfrom
fix/gfql-entity-metadata-multi-alias-2333
Draft

lmeyerov wants to merge 4 commits into
masterfrom
fix/gfql-entity-metadata-multi-alias-2333

Conversation

@lmeyerov

@lmeyerov lmeyerov commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Generalization

Multi-alias Cypher binding rows now evaluate keys(n)/properties(n) and keys(r)/properties(r) against the selected entity's own property view, rather than enumerating join suffixes and other aliases' prefixed columns. The same resolved identity is used by node entity/identity expressions when a binding marker shadows a user column.

Polars and polars-gpu retain their structured unsupported-row-expression decline for these metadata expressions.

Cross-engine incl polars-gpu

  • Tests parametrize pandas, cuDF, Polars, and polars-gpu.
  • Pandas and cuDF assert the exact property keys and selected-node property values.
  • Polars and polars-gpu assert the existing parity-or-error behavior with NotImplementedError / GFQLUnsupportedError; no pandas bridge is added.
  • Multi-alias Cartesian bindings, connected relationship bindings, and selected-alias property isolation are covered, including same-named properties on both endpoints.

Cross-platform and version

  • Exact head: 8fa4518dd67688c1e29da4c8bff32e72f774113c.
  • Exact-head hosted CI run 44182194378 is terminal green; CodeQL 44182194286 and Read the Docs pass.
  • Desktop focused new/legacy node-metadata tests pass.
  • Changed-file Ruff and diff checks pass.
  • Mypy remains at the local master baseline: 18 diagnostics, zero delta.
  • RAPIDS 25.02/26.02 and polars-gpu validation remain pending; the hosted Polars lanes in exact-head run 44182194378 are green.

Tests

  • New tests are red-first on pandas and Polars.
  • keys(n) pins the property-key list and properties(n) pins rendered property text.
  • Existing map/null keys tests and related lowering tests remain green.

Hygiene

  • Mypy has zero delta versus master.
  • Ruff and git diff --check pass.
  • CHANGELOG documents the user-visible behavior.
  • No broad exception handling is added.

Size

  • One metadata-evaluation topic: selected-entity metadata and identity survive multi-alias binding-row context.

Fixes #2333.

🤖 Generated with Codex

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GFQL Cypher: keys(n) in multi-alias queries returns internal binding columns (size 6 instead of 2)

1 participant