Skip to content

fix(gfql): align string subscripts with property access - #2351

Draft
lmeyerov wants to merge 2 commits into
masterfrom
fix/gfql-subscript-property-parity-2336
Draft

lmeyerov wants to merge 2 commits into
masterfrom
fix/gfql-subscript-property-parity-2336

Conversation

@lmeyerov

@lmeyerov lmeyerov commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Generalization

Constant-string property subscripts now resolve through the same selected-entity property view as dotted access. n['type'], n['id'], n['label__Foo'], and ordinary n['key'] work consistently across binding rows, including constant concatenation and string parameter keys. Dynamic keys that cannot be resolved at compile time continue to decline.

Cross-engine incl polars-gpu

  • Tests parametrize pandas, cuDF, Polars, and polars-gpu.
  • Pandas and cuDF resolve binding-row and bare-alias subscripts directly.
  • Polars lowers literal and constant-concatenation subscripts to the existing native property-access lowering; unsupported dynamic keys retain the parity-or-error decline.
  • Existing mapping, null, list-subscript, and dynamic-lookup controls remain covered.

Cross-platform and version

  • Exact head: c6f22b7779ceecc5b617c010c9ee5988ca5b3094.
  • Paired TCK branch 559495ae35886d6d4b8c599a5c6231754f27b5d2 is DRAFT tck-gfql [BUG] Neptune p3.16 instance does not start #220.
  • Dispatched exact-head CI run 44190433826 is terminal green; CodeQL 44188821613 and Read the Docs pass.
  • Desktop focused subscript parity: 12 passed, 12 GPU-only skipped, 0 failed.
  • Polars lane-completeness: 13 passed, 0 failed.
  • Ruff, diff-check, shell syntax, and type-hygiene pass.
  • Mypy remains at the local two-module master baseline: 18 diagnostics, zero delta.
  • RAPIDS 25.02/26.02 and polars-gpu validation remain pending; exact-head hosted CI is green.

Tests

  • New tests are red-first on pandas and Polars for reserved, label-flag, ID, and ordinary properties.
  • New controls cover constant concatenation and string-parameter keys.
  • Existing dynamic property lookup and mapping/list subscript tests pass.

Hygiene

  • Mypy has zero delta versus master.
  • Type-hygiene guard reports no growth.
  • Ruff, diff-check, and shell syntax pass.
  • CHANGELOG documents the user-visible behavior.

Size

  • One read-side topic: constant-string entity subscripts match property-access provenance.

Fixes #2336.

🤖 Generated with Codex

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GFQL Cypher: n['type'] / n['id'] / n['label__X'] subscripts return null on pandas/cuDF while n.type works

1 participant