Skip to content

fix(gfql): preserve comprehension-local map properties - #2355

Draft
lmeyerov wants to merge 2 commits into
masterfrom
fix/gfql-map-properties-2339
Draft

lmeyerov wants to merge 2 commits into
masterfrom
fix/gfql-map-properties-2339

Conversation

@lmeyerov

@lmeyerov lmeyerov commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Generalization

properties() of a mapping-valued Series now returns the mapping unchanged. A comprehension-local map such as [m IN [{a: 1}] | properties(m)] no longer falls through to entity-text rendering or a backend-specific bare error.

Cross-engine incl polars-gpu

  • Tests parametrize pandas, cuDF, Polars, and polars-gpu.
  • pandas/cuDF support mapping-value identity; Polars/polars-gpu retain their existing structured parity-or-error native decline.
  • Mapping identity is restricted to properties(); keys(), labels(), type(), and direct-map/entity rendering are unchanged.

Cross-platform and version

  • Exact head: 97e0a2e2710ec7711b1f1c7a0985096a2e4a61c8.
  • Exact tree: 20eddcbc4dc25a7d86b605e444e3bb708e878f46.
  • Full diff SHA-256: 5a0923f2f8b6d5c89b582658732429c34b19e7c12a40a9887125f9b19b0b41d8.
  • Master red proof: pandas reported the comprehension-local map as unsupported before repair.
  • Desktop focused mapping/properties/lowering scope passes; related desktop cuDF setup failures are existing no-device failures.
  • Full TCK runner against TCK main df72ca0: 3,845 passed, 5 skipped, 693 xfailed, 0 failed.
  • Ruff, diff checks, debug sweep, credential sweep, type-hygiene, and Polars lane-completeness pass.
  • Mypy remains at the master baseline: 18 diagnostics with an identical normalized set.
  • Exact-head CI run 44226878110 and CodeQL run 44226878070 are terminal green, including TCK, coverage, route modes, and Polars lanes.
  • Actual cuDF, polars-gpu, and RAPIDS 25.02/26.02 validation remain pending. The DRAFT is not ready for merge.

Tests

  • New tests are red-first and cover mapping identity on pandas/cuDF plus explicit Polar/GPU declines.
  • Existing properties() map-literal, null, entity, and lowering controls remain covered.
  • The new engine-parametrized module is registered in the Polars lane.

Hygiene

  • Mypy has zero diagnostic delta versus master.
  • Type-hygiene guard reports no growth.
  • Ruff and git diff --check pass.
  • CHANGELOG documents the user-visible Cypher behavior.

Size

  • One read-side metadata topic: comprehension-local properties() mapping fidelity.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant