Draft
Conversation
Contributor
|
Preview is ready. |
makhnatkin
reviewed
Mar 10, 2025
| "require": { | ||
| "types": "./build/cjs/extensions/*", | ||
| "default": "./build/cjs/extensions/*" | ||
| "types": "./build/cjs/extensions/*/index.d.ts", |
Collaborator
There was a problem hiding this comment.
Hi! We’ve reviewed the pull request and have a couple of suggestions:
- We recommend using absolute paths to the
indexfile in all extensions fromadditional. - The same applies to the
viewfolder.
Member
There was a problem hiding this comment.
Example:
"./extensions/Mermaid": {
"default": "./build/cjs/extensions/additional/Mermaid/index.js",
},
"./view/mermaid": {
"default": "./build/cjs/view/mermaid.js", // here exports all things related to diplodoc/mermaid-extension in src/view
},
Collaborator
|
@ogonkov is it still actual? |
Contributor
Author
|
I think yes, i will make changes that we discuss later |
Contributor
|
Visual Tests Report is ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current exports seems dosn't work at all, looks like TS just guess path with old
moduleResolution, and fail to resolve anything with newmoduleResolution: bundlerTrace of resolution with node10 resolution