Skip to content

feat(design)!: remove daff-configure-theme function - #4671

Open
xelaint wants to merge 1 commit into
developfrom
feat/remove-configure-theme
Open

feat(design)!: remove daff-configure-theme function#4671
xelaint wants to merge 1 commit into
developfrom
feat/remove-configure-theme

Conversation

@xelaint

@xelaint xelaint commented Aug 20, 2026

Copy link
Copy Markdown
Member

PR Checklist

  • Commit message follows our contributing guidelines
  • Tests added/updated (for bug fixes/features)
  • Documentation added/updated (for bug fixes/features)

PR Type

  • Bug fix
  • Feature
  • Style update
  • Refactor
  • Test
  • Build
  • CI
  • Docs
  • Performance
  • Other (please describe)

Current behavior

Fixes: #4139

New behavior

Breaking change?

  • Yes
  • No

BREAKING CHANGE: The daff-configure-theme function has been removed from @daffodil/design. Use daff-create-theme instead.

Additional context

@xelaint
xelaint requested a review from a team as a code owner August 20, 2026 21:37
@xelaint xelaint added package: design @daffodil/design 🚨 breaking changes This PR or issue will cause a breaking change status: pending review This PR is awaiting review or response from a reviewer before the author can proceed. labels Aug 20, 2026
@xelaint
xelaint requested a review from damienwebdev August 20, 2026 21:37
@xelaint

xelaint commented Aug 20, 2026

Copy link
Copy Markdown
Member Author

@griest024 the update you made in #4670 seems to be breaking linting

@griest024

Copy link
Copy Markdown
Member

@griest024 the update you made in #4670 seems to be breaking linting

Hmm odd that the ci passed on that PR, I'll take a look

BREAKING CHANGE: The `daff-configure-theme` function has been removed from `@daffodil/design`. Use `daff-create-theme` instead.
@xelaint
xelaint force-pushed the feat/remove-configure-theme branch from c58bcd4 to b3fa803 Compare August 24, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🚨 breaking changes This PR or issue will cause a breaking change package: design @daffodil/design status: pending review This PR is awaiting review or response from a reviewer before the author can proceed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove daff-configure-theme in v0.95.0

2 participants