Skip to content

Bugfix in _add_distributed_constraint#201

Merged
JordiManyer merged 3 commits intomasterfrom
bugfix-fespaces
Mar 24, 2026
Merged

Bugfix in _add_distributed_constraint#201
JordiManyer merged 3 commits intomasterfrom
bugfix-fespaces

Conversation

@JordiManyer
Copy link
Member

While porting to Gridap v0.20, I did not contemplate the case where the FESpace has multiple reffes. See gridap/GridapEmbedded.jl#120

@codecov
Copy link

codecov bot commented Mar 23, 2026

Codecov Report

❌ Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.56%. Comparing base (cbd7197) to head (fb5aa1e).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
src/FESpaces.jl 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
- Coverage   84.68%   84.56%   -0.12%     
==========================================
  Files          16       16              
  Lines        4237     4238       +1     
==========================================
- Hits         3588     3584       -4     
- Misses        649      654       +5     
Flag Coverage Δ
mpi-adaptivity 45.76% <12.50%> (-0.23%) ⬇️
mpi-fespaces 40.21% <77.77%> (-0.11%) ⬇️
mpi-geometry 23.36% <12.50%> (-0.24%) ⬇️
mpi-misc 50.33% <77.77%> (-0.11%) ⬇️
mpi-physics 35.50% <12.50%> (-0.23%) ⬇️
mpi-transient 25.01% <12.50%> (-0.24%) ⬇️
seq-adaptivity 39.66% <12.50%> (-0.23%) ⬇️
seq-fespaces 41.91% <77.77%> (-0.11%) ⬇️
seq-geometry 23.40% <12.50%> (-0.24%) ⬇️
seq-misc 35.11% <12.50%> (-0.23%) ⬇️
seq-physics 35.50% <12.50%> (-0.23%) ⬇️
seq-transient 24.24% <12.50%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JordiManyer JordiManyer merged commit b546015 into master Mar 24, 2026
26 of 29 checks passed
@JordiManyer JordiManyer deleted the bugfix-fespaces branch March 24, 2026 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant