Fix camera rotation#206
Open
albertvaka wants to merge 2 commits into
Open
Conversation
Ensure rotation and scale happen after translation, and from the center of the camera. Fixes grimfang4#133 and grimfang4#124
This was referenced Oct 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure rotation happen after translation, so it's done from the center of the camera, and scale happens first so it is independent of translation.
Fixes #26, #124, #133 and #198.
I can't think of a use case where the previous order would be desired, but if it is we could turn the
use_centered_originboolean into an enum and support all different options (more in the line of #133).