Adjust ASN.1 encoding for OTP 28 #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'OTP-PUB-KEY' --> 'OTP-PKIX' for OTP 28 or younger.
ziopio
reviewed
Nov 18, 2025
| der_encode_Integer(Int) -> | ||
| <<T:8, _L:8, V/binary>> = | ||
| element(2, 'OTP-PUB-KEY':encode('CertificateSerialNumber', Int)), | ||
| element(2, (pkix_module()):encode('CertificateSerialNumber', Int)), |
Member
There was a problem hiding this comment.
By opening an erlang shell you can check this is not supported:
12> 'OTP-PKIX':encode('CertificateSerialNumber', 3333).
{error,{asn1,{{undefined_type,'CertificateSerialNumber'},
[{'OTP-PKIX',encode_disp,2,
[{file,"../src/OTP-PKIX.erl"},{line,221}]},
{'OTP-PKIX',encode,2,
[{file,"../src/OTP-PKIX.erl"},{line,134}]},
{erl_eval,do_apply,7,[{file,"erl_eval.erl"},{line,924}]},
{shell,exprs,7,[{file,"shell.erl"},{line,965}]},
{shell,eval_exprs,7,[{file,"shell.erl"},{line,921}]},
{shell,eval_loop,4,[{file,"shell.erl"},{line,906}]}]}}}
ziopio
reviewed
Nov 18, 2025
| ++ [48,48,48,48,48,48,90], | ||
| <<T:8, _L:8, V/binary>> = | ||
| element(2, 'OTP-PUB-KEY':encode('InvalidityDate', TimeString)), | ||
| element(2, (pkix_module()):encode('InvalidityDate', TimeString)), |
Member
There was a problem hiding this comment.
This type InvalidityDate seams to be supported by the API
public_key:der_encode('IvalidityDate', "ergreg").
** exception error: no function clause matching public_key:get_asn1_module('IvalidityDate') (public_key.erl:636)
in function public_key:der_encode/2 (public_key.erl:973)
15> public_key:der_encode('InvalidityDate', "ergreg").
** exception error: no case clause matching "ergreg"
in function 'PKIX1Implicit-2009':'-getenc_CertExtensions/1-fun-0-'/3 (../src/PKIX1Implicit-2009.erl:3128)
in call from pubkey_cert_records:'-encode_extensions/1-fun-0-'/1 (pubkey_cert_records.erl:488)
in call from lists:map/2 (lists.erl:2385)
in call from public_key:der_encode/2 (public_key.erl:970)
16>
Member
Author
There was a problem hiding this comment.
You need to put a correct InvalidityDate format in there I guess, I'll check how that would look like. But the type is definitely there.
Member
Author
There was a problem hiding this comment.
Ugh ...
3> grisp_cryptoauth_cert:der_encode_GeneralizedTime({{2025, 11, 18}, undefined}).
** exception error: no match of right hand side value
{asn1,{{undefined_type,'InvalidityDate'},
[{'OTP-PKIX',encode_disp,2,
[{file,"../src/OTP-PKIX.erl"},{line,221}]},
{'OTP-PKIX',encode,2,
[{file,"../src/OTP-PKIX.erl"},{line,134}]},
{grisp_cryptoauth_cert,der_encode_GeneralizedTime,1,
[{file,"grisp_cryptoauth_cert.erl"},{line,273}]},
{erl_eval,do_apply,7,[{file,"erl_eval.erl"},{line,924}]},
{shell,exprs,7,[{file,"shell.erl"},{line,965}]},
{shell,eval_exprs,7,[{file,"shell.erl"},{line,921}]},
{shell,eval_loop,4,[{file,"shell.erl"},{line,906}]}]}}
Member
There was a problem hiding this comment.
Yeah it needs a valid date, but at least public_key:der_encode( seams to support 'IvalidityDate', problem is with the others, expecially EmailAddress and CertificateSerialNumber, we will probably need to do something else for these
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'OTP-PUB-KEY' --> 'OTP-PKIX' for OTP 28 or younger.