fix(ci): prevent burned tags by delaying tag push#67
Merged
Conversation
- Create tag locally BEFORE GoReleaser (not pushed yet) - GoReleaser creates GitHub release which auto-pushes the tag - If GoReleaser fails, tag is NOT pushed = version NOT burned - Add verification step to ensure tag was pushed This matches the approach from Carlos Becker (GoReleaser author): https://carlosbecker.com/posts/goreleaser-create-tag-action/ Fixes the issue where failed releases would burn version numbers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevents version numbers from being "burned" when GoReleaser fails.
Problem
Previous workflow:
Solution
New workflow (based on Carlos Becker's approach):
Changes
git push origin "$TAG"before GoReleaserReferences