fix(release): use git changelog instead of github API#70
Merged
Conversation
GoReleaser's github changelog mode fails when tag is not yet pushed to remote (our workflow pushes tag AFTER GoReleaser). Switch to git mode which uses local git log.
kolkov
force-pushed
the
fix/goreleaser-changelog
branch
from
62446cd to
eb79dcf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GoReleaser's
changelog.use: githubfails with 404 when the tag is not yet pushed to remote. Our release workflow creates the tag locally and pushes it only after GoReleaser succeeds — so the GitHub compare API can't find it.Switch to
changelog.use: gitwhich generates changelog from local git log.Error:
GET .../compare/v0.9.1...v0.9.4: 404 Not Found