Skip to content

[Task-9] As a user, I can see lazy loading page while waiting for survey - #45

Open
gutakk wants to merge 16 commits into
feature/task-8-reset-password-frontendfrom
feature/task-9-lazy-loading
Open

gutakk wants to merge 16 commits into
feature/task-8-reset-password-frontendfrom
feature/task-9-lazy-loading

Conversation

@gutakk

@gutakk gutakk commented Jun 22, 2021

Copy link
Copy Markdown
Owner

#10

What happened 👀

  • Add lazy loader component follow the Figma design
  • Using react-loading-skeleton for the animation
  • Add lazy loader to home page
  • Add unit test

Insight 📝

N/A

Proof Of Work 📹

  • Lazy loader (desktop)
    sQfoRH9Apb

  • Lazy loader (mobile)
    Screen Shot 2564-06-22 at 17 15 22

@gutakk gutakk added this to the 0.4.0 milestone Jun 22, 2021
@gutakk gutakk self-assigned this Jun 22, 2021
@gutakk
gutakk force-pushed the feature/task-8-reset-password-frontend branch from b529410 to 1ccf5e7 Compare June 22, 2021 05:59
@gutakk
gutakk force-pushed the feature/task-9-lazy-loading branch from 91afd8f to 79161e1 Compare June 22, 2021 06:02
@gutakk
gutakk requested review from carryall and rafayet-monon June 22, 2021 10:01
@gutakk
gutakk marked this pull request as ready for review June 22, 2021 10:16
@gutakk gutakk added the @0.3.0 label Jun 22, 2021
@gutakk
gutakk force-pushed the feature/task-8-reset-password-frontend branch from 1ccf5e7 to 7813314 Compare June 24, 2021 07:27
@gutakk
gutakk force-pushed the feature/task-9-lazy-loading branch from a5060c9 to 68f4556 Compare June 24, 2021 10:32
Comment thread src/components/LazyLoader/index.tsx Outdated
Comment thread src/components/LazyLoader/index.tsx Outdated
Comment thread src/assets/stylesheets/components/_lazy-loader.scss Outdated
display: flex;
align-items: center;
justify-content: space-between;
margin-top: rem(38px);

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This margin should be 32px
image

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2564-06-28 at 16 17 40
I think it should be 38px according to the image

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. It should be 38px. But with the current margin and also there is some line height is making the distance much larger. Below two images are the current distance differences -

  • Difference between &__survey-title and &__survey-image
    image
  • Difference between &__button and &__survey-image
    image

You can use chrome extension - MeasureMate to easily measure these distances. It's really helpful.

I also think difference between &__survey-title and &__survey-subtitle is a bit larger. I cannot say for certain because the differences are not shown in figma.

The below style changes should fix the issue. You will get nice 38px distance as well as the 32px.

&__footer {
  margin-top: rem(32px);
  line-height: 0;
}

&__survey-subtitle .react-loading-skeleton {
  margin-top: rem(8px);
}

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion. Fixed in de50d2f

@gutakk
gutakk force-pushed the feature/task-9-lazy-loading branch from 68f4556 to 4c56b44 Compare June 28, 2021 08:39
@gutakk
gutakk requested a review from rafayet-monon June 28, 2021 09:18
@gutakk
gutakk force-pushed the feature/task-8-reset-password-frontend branch from 6603b2e to 400862d Compare June 29, 2021 07:14
@gutakk
gutakk force-pushed the feature/task-9-lazy-loading branch from ac06f54 to 5817332 Compare June 29, 2021 07:18
@gutakk
gutakk force-pushed the feature/task-9-lazy-loading branch from 5817332 to 6e5cb89 Compare June 29, 2021 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task-9] As a user, I can see lazy loading page while waiting for survey

2 participants