Conversation
gutakk
force-pushed
the
feature/task-8-reset-password-frontend
branch
from
June 22, 2021 05:59
b529410 to
1ccf5e7
Compare
gutakk
force-pushed
the
feature/task-9-lazy-loading
branch
from
June 22, 2021 06:02
91afd8f to
79161e1
Compare
gutakk
marked this pull request as ready for review
June 22, 2021 10:16
gutakk
force-pushed
the
feature/task-8-reset-password-frontend
branch
from
June 24, 2021 07:27
1ccf5e7 to
7813314
Compare
gutakk
force-pushed
the
feature/task-9-lazy-loading
branch
from
June 24, 2021 10:32
a5060c9 to
68f4556
Compare
| display: flex; | ||
| align-items: center; | ||
| justify-content: space-between; | ||
| margin-top: rem(38px); |
Collaborator
Owner
Author
Collaborator
There was a problem hiding this comment.
I agree. It should be 38px. But with the current margin and also there is some line height is making the distance much larger. Below two images are the current distance differences -
- Difference between
&__survey-titleand&__survey-image

- Difference between
&__buttonand&__survey-image

You can use chrome extension - MeasureMate to easily measure these distances. It's really helpful.
I also think difference between &__survey-title and &__survey-subtitle is a bit larger. I cannot say for certain because the differences are not shown in figma.
The below style changes should fix the issue. You will get nice 38px distance as well as the 32px.
&__footer {
margin-top: rem(32px);
line-height: 0;
}
&__survey-subtitle .react-loading-skeleton {
margin-top: rem(8px);
}
gutakk
force-pushed
the
feature/task-9-lazy-loading
branch
from
June 28, 2021 08:39
68f4556 to
4c56b44
Compare
gutakk
force-pushed
the
feature/task-8-reset-password-frontend
branch
from
June 29, 2021 07:14
6603b2e to
400862d
Compare
gutakk
force-pushed
the
feature/task-9-lazy-loading
branch
from
June 29, 2021 07:18
ac06f54 to
5817332
Compare
added 11 commits
June 29, 2021 14:41
gutakk
force-pushed
the
feature/task-9-lazy-loading
branch
from
June 29, 2021 07:42
5817332 to
6e5cb89
Compare
rafayet-monon
approved these changes
Jun 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


#10
What happened 👀
react-loading-skeletonfor the animationInsight 📝
N/A
Proof Of Work 📹
Lazy loader (desktop)

Lazy loader (mobile)
