Remove unnecessary casts - #219
Merged
Merged
Conversation
gz
approved these changes
Aug 9, 2026
| max_logical_processor_ids as u8, | ||
| smt_max_cores_for_package as u8, | ||
| ); | ||
| return (max_logical_processor_ids, smt_max_cores_for_package); |
Owner
There was a problem hiding this comment.
Suggested change
| return (max_logical_processor_ids, smt_max_cores_for_package); | |
| (max_logical_processor_ids, smt_max_cores_for_package) |
lgtm
Contributor
Author
There was a problem hiding this comment.
I believe I need to keep the return keyword, as the return statement is inside an if.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #219 +/- ##
=======================================
Coverage 39.71% 39.71%
=======================================
Files 4 4
Lines 4497 4497
=======================================
Hits 1786 1786
Misses 2711 2711 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If I am not overlooking anything, I believe these casts are redundant and can thus be safely removed.
For reference, these changes were found by an optimizer developed as a research project.
CC @nunoplopes