Skip to content

Add post_plan_delay option#7

Merged
jamielinux merged 4 commits intogzuidhof:mainfrom
jamielinux:jnguyen/rate-limit
Dec 8, 2025
Merged

Add post_plan_delay option#7
jamielinux merged 4 commits intogzuidhof:mainfrom
jamielinux:jnguyen/rate-limit

Conversation

@jamielinux
Copy link
Copy Markdown
Collaborator

Add a post_plan_delay option so make it possible to configure how long flipper should wait after executing a plan (eg, to prevent quick-fire execution loops).

Also, previously the hardcoded 1s delay came before the Plan executed successfully message, so I've also moved the time.Sleep to after that message.

I made the post_plan_delay default 1s, as the previously hardcoded 1s is like a global default anyway since Hetzner is the only supported provider. (Though maybe there's an argument for the default to be 0. 🤔)

Copy link
Copy Markdown
Owner

@gzuidhof gzuidhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :) A name proposal is perhaps call it pause instead of delay? (I'm not a native speaker, so you decide what makes more sense!).

Comment thread monitor/group.go
Comment thread README.md Outdated
@jamielinux
Copy link
Copy Markdown
Collaborator Author

A name proposal is perhaps call it pause instead of delay?

Both can work :)

Though perhaps pause can imply that something stops until it's explicitly resumed. So I lean delay!

@jamielinux jamielinux merged commit 8ec4926 into gzuidhof:main Dec 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants