Add post_plan_delay option#7
Merged
jamielinux merged 4 commits intogzuidhof:mainfrom Dec 8, 2025
jamielinux:jnguyen/rate-limit
Merged
Add post_plan_delay option#7jamielinux merged 4 commits intogzuidhof:mainfrom jamielinux:jnguyen/rate-limit
jamielinux merged 4 commits intogzuidhof:mainfrom
jamielinux:jnguyen/rate-limit
Conversation
gzuidhof
approved these changes
Dec 8, 2025
Owner
gzuidhof
left a comment
There was a problem hiding this comment.
Looks good :) A name proposal is perhaps call it pause instead of delay? (I'm not a native speaker, so you decide what makes more sense!).
Collaborator
Author
Both can work :) Though perhaps |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
post_plan_delayoption so make it possible to configure how long flipper should wait after executing a plan (eg, to prevent quick-fire execution loops).Also, previously the hardcoded 1s delay came before the
Plan executed successfullymessage, so I've also moved thetime.Sleepto after that message.I made the
post_plan_delaydefault 1s, as the previously hardcoded 1s is like a global default anyway since Hetzner is the only supported provider. (Though maybe there's an argument for the default to be0. 🤔)