Upgrading go to 1.25.0, vips to 8.16 and changing base image to trixi… #444

panperla · 2025-08-26T13:59:43Z

Upgrade to golang 1.25.0
Upgrade golangcilint to 2.4.0
Migration of linter config
Update bullseye to trixie
Removed building libvips from source in favour of using version available in trixie distro (8.16)
Resolved all problems rised by linter
Replaced io/ioutil with io

…e which consist all latest libs

Copilot

Pull Request Overview

This PR modernizes the codebase by updating dependencies, replacing deprecated APIs, and migrating to newer Go versions. However, it contains several critical issues that will prevent the code from compiling and running correctly.

Key Changes:

Replaces deprecated io/ioutil package with io and os equivalents
Updates Go version and dependencies
Fixes a logical bug in HTTP status code validation
Improves error handling in server shutdown

Reviewed Changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
source_http.go	Replaces `ioutil` with `io` package and fixes HTTP status code logic bug
source_fs_test.go	Removes unused `ioutil` import and simplifies test setup
source_fs.go	Replaces `ioutil.ReadFile` with `os.ReadFile` and fixes spacing
source_body.go	Replaces `ioutil.ReadAll` with `io.ReadAll`
server.go	Improves graceful shutdown by using `log.Printf` instead of `log.Fatalf`
placeholder.go	Replaces `ioutil.ReadAll` with `io.ReadAll`
options.go	Adds new `Palette` field to `ImageOptions`
middleware.go	Adds duplicate variable declaration (bug) and modernizes string replacement
imaginary.go	Replaces `ioutil.ReadFile` with `os.ReadFile`
image.go	Replaces `ioutil.ReadAll` with `io.ReadAll`
go.sum	Updates dependency checksums
go.mod	Updates Go version to 1.25.0 (non-existent) and dependency versions
error.go	Modernizes string operations using `ReplaceAll` and `fmt.Fprintf`
Dockerfile	Updates base images, Go version, and module paths with mismatches
.golangci.toml	Updates linter configuration with incorrect section names

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-08T19:58:31Z

.golangci.toml

+[linters.settings]
+[linters.settings.depguard]
+  [linters.settings.depguard.rules.main]
+    allow = [
+      "$gostd",
+      "github.com/h2non/bimg",
+      "github.com/rs/cors",
+      "github.com/throttled/throttled/v2",
+      "github.com/throttled/throttled/v2/store/memstore",
+      "github.com/h2non/filetype",
+    ]

-    [linters-settings.misspell]
-        locale = "US"
+[linters.settings.goconst]
+min-len = 2
+min-occurrences = 2

-[linters]
-    # White-listing, to be more CI safe.
-    disable-all = true
-
-    # @see https://github.com/golangci/golangci-lint#enabled-by-default-linters
-    enable = [
-        "staticcheck",
-        "gosimple",
-        "ineffassign",
-        "typecheck",
-        "govet",
-#        "errcheck",
-        "unused",
-        "structcheck",
-        "varcheck",
-        "deadcode",
-
-        "stylecheck",
-        "gosec",
-        "interfacer",
-        "unconvert",
-#        "goconst",
-        "gocyclo",
-#        "maligned",
-        "depguard",
-        "misspell",
-        "unparam",
-        "scopelint", # Would like to ignore *_test.go files, but can't atm.
-        "gocritic",
-    ]
+[linters.settings.gocyclo]
+min-complexity = 20
+
+[linters.settings.misspell]
+locale = 'US'


The configuration section [linters.settings] is incorrect. In golangci-lint, linter settings should be under [linters-settings] (with a hyphen), not [linters.settings] (with a dot). This will prevent all linter-specific settings (depguard, goconst, gocyclo, misspell) from being applied correctly.

Copilot · 2025-11-08T19:58:31Z

Dockerfile

-
-# Cache go modules
-ENV GO111MODULE=on
+WORKDIR ${GOPATH}/src/github.com/panperla/imaginary


The WORKDIR path has been changed to github.com/panperla/imaginary, but the module name in go.mod remains github.com/h2non/imaginary. This mismatch will cause build issues. Either update go.mod to match this path, or revert this change to github.com/h2non/imaginary.

Suggested change

WORKDIR ${GOPATH}/src/github.com/panperla/imaginary

WORKDIR ${GOPATH}/src/github.com/h2non/imaginary

Copilot · 2025-11-08T19:58:31Z

middleware.go

 	wrappedStore := throttled.WrapStoreWithContext(store)

 	quota := throttled.RateQuota{MaxRate: throttled.PerSec(o.Concurrency), MaxBurst: o.Burst}
+	wrappedStore := throttled.WrapStoreWithContext(store)


Duplicate variable declaration. wrappedStore is already declared on line 73. This will cause a compilation error.

Suggested change

wrappedStore := throttled.WrapStoreWithContext(store)

wrappedStore = throttled.WrapStoreWithContext(store)

Copilot · 2025-11-08T19:58:32Z

.golangci.toml

+[linters.exclusions]
+generated = 'lax'
+presets = [
+  'comments',
+  'common-false-positives',
+  'legacy',
+  'std-error-handling'
+]
+paths = [
+  'third_party$',
+  'builtin$',
+  'examples$'
+]
+
+[formatters]
+[formatters.exclusions]
+generated = 'lax'
+paths = [
+  'third_party$',
+  'builtin$',
+  'examples$'
+]


The configuration section linters.exclusions is incorrect. In golangci-lint v2, issue exclusions should be configured under the issues section (e.g., issues.exclude-rules), not linters.exclusions.

Suggested change

[linters.exclusions]

generated = 'lax'

presets = [

'comments',

'common-false-positives',

'legacy',

'std-error-handling'

]

paths = [

'third_party$',

'builtin$',

'examples$'

]

[formatters]

[formatters.exclusions]

generated = 'lax'

paths = [

'third_party$',

'builtin$',

'examples$'

]

[issues]

# Exclude generated files (default in golangci-lint v2, but can be set explicitly)

exclude-generated = true

# Exclude issues matching these regular expressions

exclude = [

# Add patterns for comments, common false positives, legacy, std-error-handling if needed

# Example: "error return value not checked.*",

]

# Exclude issues in these paths

exclude-paths = [

'third_party$',

'builtin$',

'examples$'

]

[formatters]

Copilot · 2025-11-08T19:58:32Z

.golangci.toml

+[formatters]
+[formatters.exclusions]
+generated = 'lax'
+paths = [
+  'third_party$',
+  'builtin$',
+  'examples$'
+]


The formatters section is not a valid top-level configuration section in golangci-lint. This configuration will have no effect.

Suggested change

[formatters]

[formatters.exclusions]

generated = 'lax'

paths = [

'third_party$',

'builtin$',

'examples$'

]

Copilot · 2025-11-08T19:58:32Z

Dockerfile

    -o ${GOPATH}/bin/imaginary \
    -ldflags="-s -w -h -X main.Version=${IMAGINARY_VERSION}" \
-    github.com/h2non/imaginary
+    github.com/panperla/imaginary


The build path has been changed to github.com/panperla/imaginary, but the module name in go.mod remains github.com/h2non/imaginary. This mismatch will cause the build to fail. Either update go.mod to match this path, or revert this change to github.com/h2non/imaginary.

Upgrading go to 1.25.0, vips to 8.16 and changing base image to trixi…

7931f4e

…e which consist all latest libs

panperla mentioned this pull request Aug 26, 2025

Fixes a handful of low/medium security issues #443

Open

panperla and others added 2 commits August 26, 2025 17:03

fixing module

906f4d6

Merge branch 'master' into UPGRADE

d329155

h2non requested a review from Copilot November 8, 2025 19:54

Copilot AI reviewed Nov 8, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Upgrading go to 1.25.0, vips to 8.16 and changing base image to trixi… #444

Upgrading go to 1.25.0, vips to 8.16 and changing base image to trixi… #444

Uh oh!

panperla commented Aug 26, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 8, 2025

Uh oh!

Copilot AI Nov 8, 2025

Uh oh!

Copilot AI Nov 8, 2025

Uh oh!

Copilot AI Nov 8, 2025

Uh oh!

Copilot AI Nov 8, 2025

Uh oh!

Copilot AI Nov 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	WORKDIR ${GOPATH}/src/github.com/panperla/imaginary
	WORKDIR ${GOPATH}/src/github.com/h2non/imaginary

	wrappedStore := throttled.WrapStoreWithContext(store)
	wrappedStore = throttled.WrapStoreWithContext(store)

Uh oh!

Upgrading go to 1.25.0, vips to 8.16 and changing base image to trixi… #444

Are you sure you want to change the base?

Upgrading go to 1.25.0, vips to 8.16 and changing base image to trixi… #444

Uh oh!

Conversation

panperla commented Aug 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

panperla commented Aug 26, 2025 •

edited

Loading