Update setup.py#209
Merged
Merged
Conversation
kurtmckee
approved these changes
Feb 10, 2026
kurtmckee
left a comment
kurtmckee
left a comment
There was a problem hiding this comment.
@michaelmior I'm able to confirm this bug. It appears that this is the classic "not-using-a-src-directory" bug. Having jsonpath_ng/ as a top-level directory appears to have masked this problem.
In addition to merging this PR to address the failure, jsonpath-ng needs to migrate to a src-based directory layout to detect failures like this in the future.
kurtmckee
added a commit
to kurtmckee/pr-jsonpath-ng
that referenced
this pull request
Mar 22, 2026
This prevents the test suite from accidentally passing when a packaging problem is masked by `jsonpath_ng` being importable from the root of the repository. See h2non#209 for a PR that demonstrates the consequences of having `jsonpath_ng/` as a folder in the root of the repo. In addition, this migrates from `setup.py` to `pyproject.toml`. With this change, the project can be built with these commands: ``` pip install build python -m build ```
kurtmckee
added a commit
to kurtmckee/pr-jsonpath-ng
that referenced
this pull request
Mar 22, 2026
This prevents the test suite from accidentally passing when a packaging problem is masked by `jsonpath_ng` being importable from the root of the repository. See h2non#209 for a PR that demonstrates the consequences of having `jsonpath_ng/` as a folder in the root of the repo. In addition, this migrates from `setup.py` to `pyproject.toml`. With this change, the project can be built with these commands: ``` pip install build python -m build ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle:
Enable installing the package via pip with correct
_plyresolution