feat: update UserEmploymentHistory to use ModernJobTitle FK#656
Open
mrigasiyer wants to merge 2 commits intohackforla:mainfrom
Open
feat: update UserEmploymentHistory to use ModernJobTitle FK#656mrigasiyer wants to merge 2 commits intohackforla:mainfrom
mrigasiyer wants to merge 2 commits intohackforla:mainfrom
Conversation
mrigasiyer
changed the title
Replaces the title CharField with a modern_job_title ForeignKey referencing the ModernJobTitle table. Updates admin, serializer, and tests accordingly. Closes hackforla#618
fyliu
force-pushed
the
userEmploymentHistory
branch
from
c384bda to
e66d036
Compare
fyliu
moved this to PR Needs review (automated column, do not place items here manually)
in P: PD: Project Board
Member
|
I had to update the main branch to fix some formatting, so I rebased this branch to that. There's no code changes. |
fyliu
moved this from PR Needs review (automated column, do not place items here manually)
to 👀PR being reviewed
in P: PD: Project Board
Member
|
The changes look great and works well! I just wanted to discuss another change related to this table at the meeting before approving. |
Member
Author
|
hi fang! I'm actually going to be out traveling for the next week and half so I won't be able to join a meeting for while. I'm open to discuss on slack. PM me at your best convenience! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #618
Replaces the title CharField with a modern_job_title ForeignKey referencing the ModernJobTitle table. Updates admin, serializer, and tests accordingly.
What changes did you make?
Why did you make the changes (we will use this info to test)?