quick fixes to assignReviewers #961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tektaxi
pushed a commit
that referenced
this pull request
Nov 21, 2025
* quick fixes to assignreviewers * fixed non existant fields conditional statements for assignReviewers * need to fix: reviewer1 & 2 have same name * fixed duplicate names
joshuazhou744
pushed a commit
that referenced
this pull request
Jan 15, 2026
* quick fixes to assignreviewers * fixed non existant fields conditional statements for assignReviewers * need to fix: reviewer1 & 2 have same name * fixed duplicate names
tektaxi
added a commit
that referenced
this pull request
Jan 17, 2026
#974) * Create checkin form submit endpoint * Finish hacker checkin form submit endpoint * Change checkin form spreadsheet * api route for checking in teams * Add devpost and discord tag field validation * Update db with devpost url * Add url validation: * added team checkin form status to settings * remove workshops * more validation * test * Updated email template dates and header logo * Added hackboard role support * Revert "Added hackboard role support" This reverts commit 481d303. * Feat/auto emails (#949) * Update email templates with tentative dates * Create service for sending automated status emails * Created function to find hacker by their status * API routing for automated emails * Cleaner code * API routing for getStatusCount function * Added emails.js logic to middleware and controller files * fixed authorization bug * Added hackboard role support * Revert "Added hackboard role support" This reverts commit 481d303. * update email dates --------- Co-authored-by: Joshua Zhou <[email protected]> Co-authored-by: Mika Vohl <[email protected]> Co-authored-by: Tavi Pollard <[email protected]> * Feat/create application review (#944) * not finished create app rev * Reviewer status: 1/2 works (needs to enter twice??) * Hacker Reviewer Feature * Cleaner code * remove uneccessary comments * not finished create app rev * Reviewer status: 1/2 works (needs to enter twice??) * Hacker Reviewer Feature * Cleaner code * remove uneccessary comments * not finished create app rev * Reviewer status: 1/2 works (needs to enter twice??) * Hacker Reviewer Feature * Cleaner code * remove uneccessary comments * not finished create app rev * Reviewer status: 1/2 works (needs to enter twice??) * Hacker Reviewer Feature * Cleaner code * Fixed Application Error: implemented reviewers values from feat/review_filter and fixed the default value errors for reviewer status, name, and comments * Fixed Application Error: implemented reviewers values from feat/review_filter and fixed the default value errors for reviewer status, name, and comments * fixed authorization issues by adding all routes to routes.constant.js with unique IDs * disable emails on status change by admin --------- Co-authored-by: Tavi Pollard <[email protected]> Co-authored-by: Tavi Pollard <[email protected]> * fixed merge issue with objectIDs * Added hackboard role support (#955) * Added hackboard role support * minor edits to hackboard permissions --------- Co-authored-by: Tavi Pollard <[email protected]> * Updated account invitation email content * Feat/assign reviewers (#959) * Assign 2 reviewers per unreviewed Hacker submitted before cutoff time. Will need a cleaning for documentation * removed to requirement that the reviewer name has to be empty (now it's just filtering if hacker was created before cutoff) * clean * Use string[] parameter instead of hardcoded names --------- Co-authored-by: JAMIE XIAO <[email protected]> * Added script for sending interest form emails (#954) * Added script for sending interest form emails * Usage comments * quick fixes to assignReviewers (#961) * quick fixes to assignreviewers * fixed non existant fields conditional statements for assignReviewers * need to fix: reviewer1 & 2 have same name * fixed duplicate names * cut off to dec 1 11:59 pm * update cutoff * date fix?? * add hacker id to team api response schema * new acceptance email * updated Marriott booking deadline * round 2 acceptance email template * updated rejection email * updated wording * added volunteer link * added applied status to validateStatus function * overrode email template to send declined emails to hackers with applied status (#972) * Finish hacker checkin form submit endpoint * format sheet name * remove checkin router dup * fix --------- Co-authored-by: Joshua Zhou <[email protected]> Co-authored-by: janekhuong <[email protected]> Co-authored-by: Mika Vohl <[email protected]> Co-authored-by: Tavi Pollard <[email protected]> Co-authored-by: Jamie Xiao <[email protected]> Co-authored-by: Tavi Pollard <[email protected]> Co-authored-by: Mika Vohl <[email protected]> Co-authored-by: JAMIE XIAO <[email protected]> Co-authored-by: Mubeen Mohammed <[email protected]>
16 tasks
tektaxi
added a commit
that referenced
this pull request
Jan 17, 2026
#974) * Create checkin form submit endpoint * Finish hacker checkin form submit endpoint * Change checkin form spreadsheet * api route for checking in teams * Add devpost and discord tag field validation * Update db with devpost url * Add url validation: * added team checkin form status to settings * remove workshops * more validation * test * Updated email template dates and header logo * Added hackboard role support * Revert "Added hackboard role support" This reverts commit 481d303. * Feat/auto emails (#949) * Update email templates with tentative dates * Create service for sending automated status emails * Created function to find hacker by their status * API routing for automated emails * Cleaner code * API routing for getStatusCount function * Added emails.js logic to middleware and controller files * fixed authorization bug * Added hackboard role support * Revert "Added hackboard role support" This reverts commit 481d303. * update email dates --------- Co-authored-by: Joshua Zhou <[email protected]> Co-authored-by: Mika Vohl <[email protected]> Co-authored-by: Tavi Pollard <[email protected]> * Feat/create application review (#944) * not finished create app rev * Reviewer status: 1/2 works (needs to enter twice??) * Hacker Reviewer Feature * Cleaner code * remove uneccessary comments * not finished create app rev * Reviewer status: 1/2 works (needs to enter twice??) * Hacker Reviewer Feature * Cleaner code * remove uneccessary comments * not finished create app rev * Reviewer status: 1/2 works (needs to enter twice??) * Hacker Reviewer Feature * Cleaner code * remove uneccessary comments * not finished create app rev * Reviewer status: 1/2 works (needs to enter twice??) * Hacker Reviewer Feature * Cleaner code * Fixed Application Error: implemented reviewers values from feat/review_filter and fixed the default value errors for reviewer status, name, and comments * Fixed Application Error: implemented reviewers values from feat/review_filter and fixed the default value errors for reviewer status, name, and comments * fixed authorization issues by adding all routes to routes.constant.js with unique IDs * disable emails on status change by admin --------- Co-authored-by: Tavi Pollard <[email protected]> Co-authored-by: Tavi Pollard <[email protected]> * fixed merge issue with objectIDs * Added hackboard role support (#955) * Added hackboard role support * minor edits to hackboard permissions --------- Co-authored-by: Tavi Pollard <[email protected]> * Updated account invitation email content * Feat/assign reviewers (#959) * Assign 2 reviewers per unreviewed Hacker submitted before cutoff time. Will need a cleaning for documentation * removed to requirement that the reviewer name has to be empty (now it's just filtering if hacker was created before cutoff) * clean * Use string[] parameter instead of hardcoded names --------- Co-authored-by: JAMIE XIAO <[email protected]> * Added script for sending interest form emails (#954) * Added script for sending interest form emails * Usage comments * quick fixes to assignReviewers (#961) * quick fixes to assignreviewers * fixed non existant fields conditional statements for assignReviewers * need to fix: reviewer1 & 2 have same name * fixed duplicate names * cut off to dec 1 11:59 pm * update cutoff * date fix?? * add hacker id to team api response schema * new acceptance email * updated Marriott booking deadline * round 2 acceptance email template * updated rejection email * updated wording * added volunteer link * added applied status to validateStatus function * overrode email template to send declined emails to hackers with applied status (#972) * Finish hacker checkin form submit endpoint * format sheet name * remove checkin router dup * fix --------- Co-authored-by: Joshua Zhou <[email protected]> Co-authored-by: janekhuong <[email protected]> Co-authored-by: Mika Vohl <[email protected]> Co-authored-by: Tavi Pollard <[email protected]> Co-authored-by: Jamie Xiao <[email protected]> Co-authored-by: Tavi Pollard <[email protected]> Co-authored-by: Mika Vohl <[email protected]> Co-authored-by: JAMIE XIAO <[email protected]> Co-authored-by: Mubeen Mohammed <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tickets:
List of changes:
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please delete options that are not relevant.
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Firmware version:
Hardware:
Toolchain:
SDK:
Questions for code reviewers?
Checklist: