Assortment of fixes - particularly for reading saved cctree.out - #17
Open
qais-yousef wants to merge 5 commits into
Open
qais-yousef wants to merge 5 commits into
qais-yousef wants to merge 5 commits into
Conversation
The mapping didn't match between what we write and read. And it seems we must write Uncompressed Numeric otherwise it doesn't work for some reason. Must use CCTreeLoadXrefDBFromDisk(). Use the non FromDisk version doesn't work. Signed-off-by: Qais Yousef <qyousef@layalina.io>
And set it as unsorted in the tag file. Some ids can't be found still and I'm not sure why. Something is tripping taglist() to find those ids. The format might not be correct enough.. Signed-off-by: Qais Yousef <qyousef@layalina.io>
It seems taglist() can get confused for very long lines Signed-off-by: Qais Yousef <qyousef@layalina.io>
We wrongly pruned nodes that were smaller than the current depth! Signed-off-by: Qais Yousef <qyousef@layalina.io>
We were creating maxdepth+1 instead of maxdepth basically. Signed-off-by: Qais Yousef <qyousef@layalina.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started with not being able to use the saved cctree.out as in #16 and ended up with a bit extra fixes on top. Which I'm not sure how good they are - particularly the one about sorting. taglist() fails to find lots of elements and I literally hacked it to reduce the error rate, but not entirely eleminated it.
It seems this project is no longer maintained - but hey in case anyone finds this useful..