fix(ci): generate desktop marketplace JSON in nightly build - #329
Merged
Conversation
nightly.yml's build-desktop job never generated apps/desktop/src/lib/marketplace/marketplace.generated.json, so tsc failed with TS2307. The nightly has been red every night since 2026-07-28. This is the same bug #323/#324 fixed in release.yml and validate.yml — nightly was a third hand-rolled copy of the same recipe and got missed. - Extract the recipe into a .github/actions/prepare-desktop-frontend composite action (workspace deps + marketplace JSON, with a strict input) - Call it from all three desktop-building jobs so the copies can't drift again - Add a report-failure job that opens/updates a nightly-failure issue on scheduled failures — the breakage sat unnoticed in Actions for four days Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The nightly build has failed every night since 2026-07-28 (4 consecutive runs).
nightly.yml'sbuild-desktopjob never generatedapps/desktop/src/lib/marketplace/marketplace.generated.json— a gitignored build output — sotscdied:This is the same class of bug #323/#324 fixed in
release.ymlandvalidate.yml. Those two workflows got the fix;nightly.ymlwas a third hand-rolled copy of the same recipe and was missed. Nightly is the only one of the three not exercised on PRs, so the drift went unnoticed.Changes
.github/actions/prepare-desktop-frontend— buildsshared/core/design-tokens/uiand generates the desktop marketplace JSON. Takes astrictinput, sincevalidate.ymlintentionally runs the generator non-strict.nightly.yml,release.yml,validate.yml). One place to change means the copies can't drift apart again.report-failurejob innightly.yml— on a scheduled failure it opens (or comments on) anightly-failureissue. This is the part that stops a silent recurrence: the breakage was visible in Actions for four days and nobody was told.Verification
Deleted
marketplace.generated.jsonlocally, ran the composite action's exact steps, thenpnpm --filter harness-kit-desktop build— thetsc && vite buildthat failed in CI. Passes, built in 13.9s. All four YAML files parse.The real proof is a
workflow_dispatchrun of Nightly off this branch once CI is green.🤖 Generated with Claude Code