Augment keys of all metric types in the same way #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanbirkner
force-pushed
the
augment-key
branch
2 times, most recently
from
ccf720f to
38e0102
Compare
Author
It is unexpected that the common key prefix for some metrics types is different. This makes it unnecessary difficult to find the metrics in the database. This commit unifies the prefix for all metrics. The prefix of each key is now `service name, type prefix, hostname`. All of them are optional. `service name` is added if it is available and not set as a label because the configuration flag `EnableServiceLabel` is set. `type prefix` is added if it is enabled with the configuration flag `EnableTypePrefix`. `hostname` is added if it is available and not set as a label because `EnableHostnameLabel` is set. The behaviour of `EmitKeys`, `IncrCounter`, `IncrCounterWithLabels`, `AddSample`, `AddSampleWithLabels`, `MeasureSince` and `MeasureSinceWithLabels` changes with this commit. For `EmitKey` the hostname will be added (details see above) but the service name will no longer be added when `EnableServiceLabel` is set to `true`. For the other types the hostname will be added if it is available and `EnableHostnameLabel` is set to `false`.
stefanbirkner
force-pushed
the
augment-key
branch
from
38e0102 to
3633199
Compare
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is unexpected that the common key prefix for some metrics types is
different. This makes it unnecessary difficult to find the metrics in
the database. This commit unifies the prefix for all metrics.
The prefix of each key is now
service name, type prefix, hostname. Allof them are optional.
service nameis added if it is available and notset as a label because the configuration flag
EnableServiceLabelisset.
type prefixis added if it is enabled with the configuration flagEnableTypePrefix.hostnameis added if it is available and not setas a label because
EnableHostnameLabelis set.The behaviour of
EmitKeys,IncrCounter,IncrCounterWithLabels,AddSample,AddSampleWithLabels,MeasureSinceandMeasureSinceWithLabelschanges with this commit. ForEmitKeythehostname will be added (details see above) but the service name will no
longer be added when
EnableServiceLabelis set totrue. For theother types the hostname will be added if it is available and
EnableHostnameLabelis set tofalse.