remove dead code from command package #27066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We never implemented a `nomad events` command, but we left a stub sitting around in the `command` package that's not wired up to anything and refers to features that we never implemented. Let's just remove it.
gulducat
approved these changes
Nov 7, 2025
Member
gulducat
left a comment
gulducat
left a comment
There was a problem hiding this comment.
Hey this command seems pretty cool, alas 😛
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We never implemented a
nomad eventscommand, but we left a stub sitting around in thecommandpackage that's not wired up to anything and refers to features that we never implemented. Let's just remove it.Bumped in this while working on #27065
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.