Skip to content

Conversation

@josnyder-2
Copy link

@josnyder-2 josnyder-2 commented Oct 30, 2025

Description

Presently, the provider reads secrets from AWS under all circumstances, even when it is configured in write-only mode by use of secret_string_wo. As a result, it is not possible for an unprivileged user who is working with a statefile that has write-only secrets to perform a terraform plan -refresh=true.

This pull request modifies the behavior so that—when in write-only mode—we use ListSecretVersionIds instead of GetSecretValue.

@github-actions
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. size/M Managed by automation to categorize the size of a PR. labels Oct 30, 2025
@josnyder-2 josnyder-2 force-pushed the b-aws_secretsmanager_secret_version_no-get-secret-value branch from 0fd466e to 18dbb12 Compare November 9, 2025 18:11
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Nov 9, 2025
@josnyder-2 josnyder-2 marked this pull request as ready for review November 9, 2025 18:11
@josnyder-2 josnyder-2 requested a review from a team as a code owner November 9, 2025 18:11
@josnyder-2 josnyder-2 force-pushed the b-aws_secretsmanager_secret_version_no-get-secret-value branch from 18dbb12 to bee00fd Compare November 10, 2025 04:49
@github-actions github-actions bot added the size/L Managed by automation to categorize the size of a PR. label Nov 10, 2025
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 11, 2025
@justinretzolk
Copy link
Member

Relates #42383
Relates #43579

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Addresses a defect in current functionality. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. size/L Managed by automation to categorize the size of a PR. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants