Password Credential support #758
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgajjala8
changed the title
bgajjala8
changed the title
bgajjala8
changed the title
bgajjala8
force-pushed
the
bgajjala-password-credential-tf
branch
2 times, most recently
from
61a39b4 to
16d8aa7
Compare
bgajjala8
force-pushed
the
bgajjala-password-credential-tf
branch
from
16d8aa7 to
c518752
Compare
bgajjala8
commented
Nov 19, 2025
| github.com/hashicorp/boundary/sdk v0.0.55 | ||
| github.com/hashicorp/boundary v0.18.1-0.20251118203559-6533c8bdb302 | ||
| github.com/hashicorp/boundary/api v0.0.59-0.20251118203559-6533c8bdb302 | ||
| github.com/hashicorp/boundary/sdk v0.0.56-0.20251118203559-6533c8bdb302 |
Collaborator
Author
There was a problem hiding this comment.
I'm pulling from main because the LLB changes have been merged. I am assuming we still need to wait for a release to use a stable the most up to date SDK version. Does that sound correct? @louisruch
Collaborator
There was a problem hiding this comment.
Right we can update this and merge it once we release boundary - though I am not sure why main is at 0.18.1-xxx
louisruch
reviewed
Nov 20, 2025
| ) | ||
|
|
||
| const ( | ||
| credentialPasswordKey = "password" |
Collaborator
There was a problem hiding this comment.
Yeah this is a bit weird because this should be credentialPasswordPasswordKey if we follow the norm as in others. Since this isn't exported and not globally needed we can leave it, but we probably should talk through a better approach to these fields going forward
bgajjala8
force-pushed
the
bgajjala-password-credential-tf
branch
from
de406f2 to
c518752
Compare
bgajjala8
force-pushed
the
bgajjala-password-credential-tf
branch
from
c518752 to
061604f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for password only credential type.