Generate Resource Config: set state in proto req #37895
Open
+80
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mildwonkey
previously approved these changes
Nov 13, 2025
3 tasks
mildwonkey
previously approved these changes
Nov 14, 2025
jbardin
reviewed
Nov 14, 2025
| body: Set state information in the proto request for the `GenerateResourceConfig` RPC | ||
| time: 2025-11-13T15:28:43.489677+01:00 | ||
| custom: | ||
| Issue: "37895" |
Member
There was a problem hiding this comment.
since this is backported to 1.14, we don't need the changelog entry for 1.15
Contributor
Changelog WarningCurrently this PR would target a v1.15 release. Please add a changelog entry for in the .changes/v1.15 folder, or discuss which release you'd like to target with your reviewer. If you believe this change does not need a changelog entry, please add the 'no-changelog-needed' label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix marshals the available state information into msgpack and sets it in the proto request for the
GenerateResourceConfigmethod.Target Release
Thinking this might want to make it into a release before 1.14 GAs
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
None
CHANGELOG entry