feat: make lease renewal threshold configurable #31636
Draft
+250
−41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes lease renewal threshold configurable in the vault agent config. Currently this is hardcorded to renew after 2/3 of the lease duration has passed. We would like this to be configurable so we can control when leased credentials are renewed.
To maintain backward compatibility, the default renewal threshold is configured as 0.667 (2/3) and this can be overridden as required with a value in the range 0-1.
Fixes #31505
Notes
I need to finish testing this but would love to know if this looks like a change that could be accepted 🙏