Skip to content

FE-422: Show readable type names in tables - #10491

Open
vilkinsons wants to merge 1 commit into
d/fe-422-data-type-label-previewsfrom
d/fe-422-readable-type-labels
Open

vilkinsons wants to merge 1 commit into
d/fe-422-data-type-label-previewsfrom
d/fe-422-readable-type-labels

Conversation

@vilkinsons

Copy link
Copy Markdown
Member

The Type column on profile pages and the main Types page displays internal names such as property-type. Show “Property Type”, “Data Type”, “Entity Type”, and “Link Type” instead. Search, copied cells, and CSV exports use the same readable labels.

This is a small follow-up to FE-422, stacked directly on #10490.

Validation: frontend TypeScript, ESLint, formatting, and whitespace checks pass. Checked the local HASH profile table in the browser and confirmed that all 2,128 exported rows use the four readable Type labels.

@vercel

vercel Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
hash Ready Ready Preview Nov 16, 2026 3:38pm UTC
petrinaut Ready Ready Preview Nov 16, 2026 3:38pm UTC
petrinaut-docs Ready Ready Preview Nov 16, 2026 3:38pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
hashdotdesign-tokens Ignored Ignored Preview Nov 16, 2026 3:38pm UTC

Request Review

@github-actions github-actions Bot added area/apps > hash* Affects HASH (a `hash-*` app) type/eng > frontend Owned by the @frontend team area/apps labels Nov 12, 2026
@vilkinsons vilkinsons self-assigned this Nov 12, 2026
@vilkinsons
vilkinsons added this pull request to stack #10489 November 12, 2026 19:56
@vilkinsons
vilkinsons requested a review from CiaranMn November 12, 2026 20:09
@vilkinsons
vilkinsons marked this pull request as ready for review November 12, 2026 20:09
Copilot AI balanced review requested due to automatic review settings November 12, 2026 20:09
@cursor

cursor Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Presentation-only mapping in the types table with no auth, data, or API changes.

Overview
The Type column on the combined Types table (and related profile views) now shows labels like Property Type and Data Type instead of internal slugs such as property-type.

A shared typeKindLabels map drives both grid cell displayData/data (so display, copy, and search match) and CSV export via a new resolveCell hook on buildCsvFile.

Reviewed by Cursor Bugbot for commit 97654e8. Bugbot is set up for automated code reviews on this repo. Configure here.

@veria-ai

veria-ai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

PR overview

No security issues were found in this pull request.

Reviews

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the shared type-table label changes.

No open issues 🎉

What changed in this PR

This follow-up to #10490 makes type names readable in the shared table used by profile pages and the main Types page.

Changes:

  • Maps internal type identifiers to “Property Type”, “Data Type”, “Entity Type”, and “Link Type”.
  • Uses the same readable labels for displayed cells, search, copied values, and CSV exports.
File Description
apps/​hash-frontend/​src/​pages/​shared/​types-table.tsx Adds shared type labels and applies them to table cells and CSV exports.

Review effort: Balanced

@vilkinsons
vilkinsons force-pushed the d/fe-422-readable-type-labels branch from 7ee55d1 to 124d581 Compare November 13, 2026 16:47
@vilkinsons
vilkinsons force-pushed the d/fe-422-readable-type-labels branch from 124d581 to 6e23780 Compare November 13, 2026 19:19
@vilkinsons
vilkinsons force-pushed the d/fe-422-readable-type-labels branch from 6e23780 to 92cec40 Compare November 16, 2026 12:48
@hashdotai
hashdotai force-pushed the d/fe-422-readable-type-labels branch from 92cec40 to d65820b Compare November 16, 2026 13:20
@vilkinsons
vilkinsons force-pushed the d/fe-422-readable-type-labels branch from d65820b to 50d8f5a Compare November 16, 2026 13:34

This branch was successfully deployed

3 active deployments
Preview – hash — 97654e8b Deployed Nov 16, 2026 by vercel[bot]
Preview – petrinaut — 97654e8b Deployed Nov 16, 2026 by vercel[bot]
Preview – petrinaut-docs — 97654e8b Deployed Nov 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/apps > hash* Affects HASH (a `hash-*` app) area/apps type/eng > frontend Owned by the @frontend team

Development

Successfully merging this pull request may close these issues.

2 participants