Skip to content

Make it compile with MicroHs #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
augustss wants to merge 7 commits into from
+8 −1
Closed

Make it compile with MicroHs #195

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d4a5d86
Make it build with MicroHs.
augustss Jan 4, 2025
26e3203
Add CI for MicroHs
augustss Jan 4, 2025
5c86374
Add missing repo
augustss Jan 4, 2025
68b6e78
Merge branch 'master' of github.com:augustss/parsec
augustss Jan 5, 2025
1de3cef
Merge branch 'haskell:master' into master
augustss Sep 5, 2025
ea88d73
Remove CI
augustss Sep 5, 2025
8e379b9
Add MonoLocalBinds since that's always on for MicroHs.
augustss Sep 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/Text/Parsec/Token.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
{-# LANGUAGE FlexibleContexts #-}
{-# LANGUAGE MonoLocalBinds #-} -- MicroHs always has MonoLocalBinds, this helps GHC catch those problems
{-# LANGUAGE PolymorphicComponents #-}
{-# LANGUAGE ScopedTypeVariables #-}
{-# LANGUAGE Safe #-}

-----------------------------------------------------------------------------
Expand Down Expand Up @@ -348,7 +350,7 @@ data GenTokenParser s u m
-- > reserved = P.reserved lexer
-- > ...

makeTokenParser :: (Stream s m Char)
makeTokenParser :: forall s m u . (Stream s m Char)
=> GenLanguageDef s u m -> GenTokenParser s u m
{-# INLINABLE makeTokenParser #-}
makeTokenParser languageDef
Expand Down Expand Up @@ -390,6 +392,8 @@ makeTokenParser languageDef
-----------------------------------------------------------
-- Bracketing
-----------------------------------------------------------
parens, braces, angles, brackets
Copy link
Collaborator

@phadej phadej Sep 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why these signatures are required, but not any others in the where block?

Copy link
Author

@augustss augustss Sep 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because MicroHs has MonoLocalBinds always on, and these need polymorphic types.

Copy link
Collaborator

@phadej phadej Sep 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add {-# LANGUAGE MonoLocalBinds #-} to module header, and an explaining comment that we need it to allow GHC to catch problematic for MHS code.

Copy link
Author

@augustss augustss Sep 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added it

:: forall a. ParsecT s u m a -> ParsecT s u m a
parens p = between (symbol "(") (symbol ")") p
braces p = between (symbol "{") (symbol "}") p
angles p = between (symbol "<") (symbol ">") p
Expand All @@ -400,6 +404,8 @@ makeTokenParser languageDef
dot = symbol "."
colon = symbol ":"

commaSep, semiSep, commaSep1, semiSep1
:: forall a. ParsecT s u m a -> ParsecT s u m [a]
commaSep p = sepBy p comma
semiSep p = sepBy p semi

Expand Down Expand Up @@ -681,6 +687,7 @@ makeTokenParser languageDef
symbol name
= lexeme (string name)

lexeme :: forall a. ParsecT s u m a -> ParsecT s u m a
lexeme p
= do{ x <- p; whiteSpace; return x }

Expand Down