chore: no need to error out when s3 bulk payloads return 404#4263
Open
mnafees wants to merge 1 commit into
Open
chore: no need to error out when s3 bulk payloads return 404#4263mnafees wants to merge 1 commit into
mnafees wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
We sure about this? If this happens, then the task we're about to trigger will have an empty input |
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts dispatcher logging to reduce alert noise when bulk payload retrieval from S3 fails due to expected “not found” conditions (e.g., expired/cleaned-up payload keys).
Changes:
- Adds
isS3NotFoundErrhelper to detect S3 “not found” errors (404 / NoSuchKey). - Downgrades bulk payload retrieval log level from
ERRORtoWARNwhen the failure is classified as an expected S3 “not found”.
Comment on lines
+648
to
+668
| func isS3NotFoundErr(err error) bool { | ||
| var nsk *types.NoSuchKey | ||
| if errors.As(err, &nsk) { | ||
| return true | ||
| } | ||
|
|
||
| var respErr *smithyhttp.ResponseError | ||
| if errors.As(err, &respErr) && respErr.HTTPStatusCode() == 404 { | ||
| return true | ||
| } | ||
|
|
||
| var apiErr smithy.APIError | ||
| if errors.As(err, &apiErr) { | ||
| switch apiErr.ErrorCode() { | ||
| case "NoSuchKey", "NotFound": | ||
| return true | ||
| } | ||
| } | ||
|
|
||
| return false | ||
| } |
gregfurman
previously approved these changes
Jun 23, 2026
gregfurman
dismissed
their stale review
Nvm. I saw Matt's comment. Will await feedback before approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Instead of treating expired and nvalid S3 keys as errors, let us only WRN for these for bulk payload processing.
Type of change
What's Changed
Checklist
Changes have been:
🤖 AI Disclosure