fix(sdks/ts): don't crash on Node watch-mode messages#4284
Open
princed wants to merge 2 commits into
Open
Conversation
|
@princed is attempting to deploy a commit to the Hatchet Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a Node watch-mode compatibility issue in the TypeScript SDK heartbeat worker. Newer Node worker reload/watch behaviour can emit internal worker-thread messages such as
watch:requireandwatch:importthrough the normalmessageevent, see nodejs/node#62368.The heartbeat controller previously assumed every worker message was a heartbeat log message and dynamically dispatched
this.logger[message.type](message.message), which can fail for those internal messages.For internal I used a much simpler fix via
yarn patch, please let me know if that's something you prefer instead, happy to update the PR.Similar problem was also encounter in other projects, e.g. https://redirect.github.com/pinojs/thread-stream/pull/213
Type of change
What's Changed
Checklist
Changes have been:
Testing
yarn linkin an affected project.🤖 AI Disclosure