fix: Deflake RemovingTenantStopsSnapshots by waiting for CleanupTenant

[igor-kupczynski]

Description

Follow up to #4257 (comment) -- a flaky test fix

Fixes # (issue)

Type of change

• Chore (changes which are not directly related to any business logic)
• Test changes (add, refactor, improve or change a test)

What's Changed

• Deflake TestScheduler_PoolIntegration_RemovingTenantStopsSnapshots by waiting for CleanupTenant before checking that removed-tenant snapshots stop.
• Replace the fixed 50ms sleep / 350ms strict no-snapshot check with a 2s quiet window and 5s overall timeout, so in-flight snapshot callbacks after removal do not fail the test.

Checklist

Changes have been:

• Tested (unit, integration, or manually with steps specified)
• Linted and formatted
• Documented (where applicable)
• Added to CHANGELOG (where applicable) -- see Keep a Changelog

🤖 AI Disclosure

• I acknowledge that an LLM was used in the creation of this Pull Request, in accordance with Hatchet's AI_POLICY.md.

• Details: Cursor drafted the plan and wrote the code with a mix of GPT-5.5 and composer-2.5

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
hatchet-docs	Ready	Preview, Comment	Jul 9, 2026 12:48pm

[github-actions]

Benchmark results

goos: linux
goarch: amd64
pkg: github.com/hatchet-dev/hatchet/pkg/scheduling/v1
cpu: AMD Ryzen 9 7950X3D 16-Core Processor          
              │ /tmp/old.txt │         /tmp/new.txt          │
              │    sec/op    │    sec/op     vs base         │
RateLimiter-8   47.28µ ± 14%   55.05µ ± 25%  ~ (p=0.310 n=6)

              │ /tmp/old.txt │         /tmp/new.txt          │
              │     B/op     │     B/op      vs base         │
RateLimiter-8   137.7Ki ± 0%   137.7Ki ± 0%  ~ (p=0.623 n=6)

              │ /tmp/old.txt │          /tmp/new.txt          │
              │  allocs/op   │  allocs/op   vs base           │
RateLimiter-8    1.022k ± 0%   1.022k ± 0%  ~ (p=1.000 n=6) ¹
¹ all samples are equal

_{Compared against main (9c2ef1c)}

[github-actions]

⚠️ Optional test failure: The load-deadlock job failed on this PR (optimistic-scheduling=false). This check is non-mandatory and does not block merging, but may be worth investigating. View logs

[github-actions]

⚠️ Optional test failure: The old-engine-new-sdk (Python) job failed on this PR. This check is non-mandatory and does not block merging, but may be worth investigating. View logs