Fixes #322 Edit votes loads only 15 images (scroll listener race condition)#418
Open
ayushshukla1807 wants to merge 4 commits intohatnote:masterfrom
Open
Fixes #322 Edit votes loads only 15 images (scroll listener race condition)#418ayushshukla1807 wants to merge 4 commits intohatnote:masterfrom
ayushshukla1807 wants to merge 4 commits intohatnote:masterfrom
Conversation
This commit patches the admin_endpoints validation to gracefully handle empty POST bodies, and modifies MessageMiddleware to intercept MontageErrors so they correctly return 400 Bad Request JSON instead of bypassing CORS headers. Resolves Issue hatnote#357.
Bind :disabled='isLoading' on vote buttons to block concurrent clicks at DOM level before Vue's async re-render cycle can prevent them.
…atnote#325) getRoundVotesStats was defined in jurorService but never called. Added onMounted fetch and post-vote refresh in VoteRating.vue and VoteYesNo.vue, with conditional rendering when round.show_stats is true.
editVoteContainer ref is inside a v-else-if block and is null at onMounted, so the scroll listener was never attached. Replaced with watch(editVoteContainer) to attach the listener once the element renders.
ayushshukla1807
force-pushed
the
fix-edit-votes-infinite-scroll
branch
from
b1b675d to
2bcec5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Edit Votes" view was failing to load more than the initial 15 images because the scroll listener was being attached in the onMounted hook. Since the container element is often toggled via v-if, the ref was null when onMounted fired, causing the listener to never be registered.
Changes:
Moved the scroll listener logic from onMounted to a watch that monitors the template ref.
Now, the listener is successfully attached the moment the DOM element is rendered.
Users can now correctly scroll through hundreds of previous votes.